eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[Enhancement] Optimize some codes

Open Alonexc opened this issue 3 years ago • 4 comments
trafficstars

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Enhancement Request

There is some code in the project that needs to be optimized. For example: 1.Located at: eventmesh/runtime/core/protocol/http/processor/BatchSendMessageProcessor.java

image

There is some commented out invalid code.

2.Located at: eventmesh/runtime/core/protocol/http/consumer/HandleMsgContext.java image

Describe the solution you'd like

1.Remove the invalid code. 2.The log can be opened and then modified to the correct code.

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Alonexc avatar Jul 12 '22 08:07 Alonexc

Can I try this issues ?

misselvexu avatar Jul 13 '22 02:07 misselvexu

Can I try this issues ?

Of course!

Alonexc avatar Jul 13 '22 02:07 Alonexc

Hi @misselvexu, not mean to offense, but I saw you commented in many issues (including other repos) without submitting PRs, can you update the status if you no longer want to work on them? Many thanks

hezean avatar Aug 04 '22 18:08 hezean

Has been finished, see #1134 .

KevinClair avatar Aug 09 '22 14:08 KevinClair