eventmesh icon indicating copy to clipboard operation
eventmesh copied to clipboard

[Bug] A boxed value is unboxed and then immediately reboxed

Open kirinzhu opened this issue 2 years ago • 1 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Environment

Mac

EventMesh version

master

What happened

A boxed value is unboxed and then immediately reboxed: Integer.valueOf(RequestCode.HEARTBEAT.getRequestCode()) The return value of getRequestCode() is already Integer

How to reproduce

In module eventmesh-runtime In class org.apache.eventmesh.runtime.core.protocol.grpc.processor.HeartbeatProcessor In method org.apache.eventmesh.runtime.core.protocol.grpc.processor.HeartbeatProcessor.doAclCheck(Heartbeat) At [line 107]

Debug logs

No response

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

kirinzhu avatar Jul 08 '22 07:07 kirinzhu

I will finish this issue .

misselvexu avatar Jul 11 '22 08:07 misselvexu

Hey team, Can I pick this?

vinayakghatul avatar Nov 29 '22 12:11 vinayakghatul

I would like to work on this issue, hence would like to request for it to be assigned to me Thanks in advance

yashchaddha avatar Jul 11 '23 21:07 yashchaddha

I would like to work on this issue, hence would like to request for it to be assigned to me Thanks in advance

welcome

Pil0tXia avatar Jul 12 '23 01:07 Pil0tXia

This issue has already been fixed https://github.com/apache/eventmesh/commit/94545dcbc96256e65ca95d7475d11bd8d3a11a24#diff-5603d7fd94b845776b2451618f4722e6b9214d69214be062d52f6e6be9fba98aR111

ruzaikr avatar Jul 22 '23 23:07 ruzaikr