echarts icon indicating copy to clipboard operation
echarts copied to clipboard

(feat): marker upgrade for stock charts

Open Ovilia opened this issue 1 year ago • 3 comments

Brief Information

This pull request is in the type of:

  • [ ] bug fixing
  • [x] new feature
  • [ ] others

What does this PR do?

Enhance the ability of markerPoint so that we can do more for stock charts.

image

Fixed issues

#19578

Details

Before: What was the problem?

We can only set the position of markPoints according to the whole canvas, but not to the grid area in pixels.

After: How does it behave after the fixing?

With relativeTo: 'coordinate', we can set the position in pixels according to the grid area.

Document Info

New API: markPoint.data.relativeTo: 'screen' | 'coordinate'

One of the following should be checked.

  • [ ] This PR doesn't relate to document changes
  • [x] The document should be updated later
  • [ ] The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • [ ] Please squash the commits into a single one when merging.

Other information

Ovilia avatar Jul 16 '24 09:07 Ovilia

Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

echarts-bot[bot] avatar Jul 16 '24 09:07 echarts-bot[bot]

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-20166@beb3636

github-actions[bot] avatar Jul 16 '24 09:07 github-actions[bot]

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

echarts-bot[bot] avatar Jul 25 '24 11:07 echarts-bot[bot]

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

echarts-bot[bot] avatar Apr 10 '25 11:04 echarts-bot[bot]