echarts icon indicating copy to clipboard operation
echarts copied to clipboard

fix(pie): fix `endAngle` is not applied on the empty circle

Open plainheart opened this issue 2 years ago • 2 comments

Brief Information

This pull request is in the type of:

  • [x] bug fixing
  • [ ] new feature
  • [ ] others

What does this PR do?

Fix a bug brought by the endAngle feature - The empty circle should take the configured endAngle into account.

Fixed issues

  • #18820

Comparison

Before After
Before After
Preview Preview

Document Info

One of the following should be checked.

  • [x] This PR doesn't relate to document changes
  • [ ] The document should be updated later
  • [ ] The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to test/pie-endAngle.html.

Others

Merging options

  • [ ] Please squash the commits into a single one when merging.

plainheart avatar Feb 24 '24 10:02 plainheart

Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

echarts-bot[bot] avatar Feb 24 '24 10:02 echarts-bot[bot]

The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19642@c539b1f

github-actions[bot] avatar Feb 24 '24 10:02 github-actions[bot]

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

echarts-bot[bot] avatar Feb 26 '24 07:02 echarts-bot[bot]