echarts icon indicating copy to clipboard operation
echarts copied to clipboard

fix(bar): barMinHeight not working for stacked bars

Open Ovilia opened this issue 3 years ago • 5 comments

Brief Information

This pull request is in the type of:

  • [x] bug fixing
  • [ ] new feature
  • [ ] others

What does this PR do?

#16338 seems to bring a bug that the first series's barMinHeight is not stacked with the second series, so that the base of the second series is barMinHeight.

Fixed issues

#16565

Details

Before: What was the problem?

If there are three series with all data as 0 and barMinHeight as 15, the three series are at the same position.

image

After: How does it behave after the fixing?

They should be stack on each other, which is the behavior before #16338.

image

Document Info

One of the following should be checked.

  • [x] This PR doesn't relate to document changes
  • [ ] The document should be updated later
  • [ ] The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • [ ] Please squash the commits into a single one when merging.

Other information

Ovilia avatar Mar 03 '23 09:03 Ovilia

Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

echarts-bot[bot] avatar Mar 03 '23 09:03 echarts-bot[bot]

Hello! Is there any news about this fix?

Arhimondear avatar Mar 31 '23 07:03 Arhimondear

Hello! Is there any news about this fix?

@Ovilia help, plz :)

Arhimondear avatar Apr 03 '23 11:04 Arhimondear

@Arhimondear This problem remains to be fixed because it is complicated. You may use 5.2.x if you are urgent.

Ovilia avatar Apr 07 '23 02:04 Ovilia

This PR is closed due to the fact that by supporting minHeight for stacked bars, it brings a misunderstanding of the total height.

Ovilia avatar Jun 20 '24 09:06 Ovilia

This PR is closed due to the fact that by supporting minHeight for stacked bars, it brings a misunderstanding of the total height.

configing minHeight is still not working

option = {
  tooltip: {
    trigger: 'axis',
    axisPointer: {
      // Use axis to trigger tooltip
      type: 'shadow' // 'shadow' as default; can also be 'line' or 'shadow'
    }
  },
  legend: {},
  grid: {
    left: '3%',
    right: '4%',
    bottom: '3%',
    containLabel: true
  },
  xAxis: {
    type: 'value'
  },
  yAxis: {
    type: 'category',
    data: ['Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat', 'Sun']
  },
  series: [
    {
      name: 'Direct',
      type: 'bar',
      stack: 'total',
      label: {
        show: true
      },
      emphasis: {
        focus: 'series'
      },
      minHeight: 560,  // This is my configuration 「minHehgit」
      data: [0, 302, 301, 334, 390, 330, 320]
    },
    {
      name: 'Mail Ad',
      type: 'bar',
      stack: 'total',
      label: {
        show: true
      },
      emphasis: {
        focus: 'series'
      },
      data: [120, 132, 101, 134, 90, 230, 210]
    },
    {
      name: 'Affiliate Ad',
      type: 'bar',
      stack: 'total',
      label: {
        show: true
      },
      emphasis: {
        focus: 'series'
      },
      data: [220, 182, 191, 234, 290, 330, 310]
    },
    {
      name: 'Video Ad',
      type: 'bar',
      stack: 'total',
      label: {
        show: true
      },
      emphasis: {
        focus: 'series'
      },
      data: [150, 212, 201, 154, 190, 330, 410]
    },
    {
      name: 'Search Engine',
      type: 'bar',
      stack: 'total',
      label: {
        show: true
      },
      emphasis: {
        focus: 'series'
      },
      data: [820, 832, 901, 934, 1290, 1330, 1320]
    }
  ]
};

chenxingshuang avatar Jul 22 '24 09:07 chenxingshuang