echarts icon indicating copy to clipboard operation
echarts copied to clipboard

fix(scale): intervalTick should between extent. close 16888

Open MeetzhDing opened this issue 3 years ago • 3 comments

Brief Information

This pull request is in the type of:

  • [x] bug fixing
  • [ ] new feature
  • [ ] others

What does this PR do?

filter intervalTick by tick.value > extent[0] && tick.value < extent[1] && !tick.notAdd;

Fixed issues

#16888

xAxis[type=time], set showMinLabel=false not work

Details

Before: What was the problem?

MeetzhDing avatar Apr 28 '22 18:04 MeetzhDing

Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

echarts-bot[bot] avatar Apr 28 '22 18:04 echarts-bot[bot]

Thanks! Could you add a test case for this?

pissang avatar Apr 29 '22 03:04 pissang

Thanks! Could you add a test case for this?

done.

image

MeetzhDing avatar Apr 29 '22 03:04 MeetzhDing

min/max labels work normal after this changing, could you check it again? Or give me a specific example ? @Ovilia

MeetzhDing avatar Aug 18 '22 09:08 MeetzhDing

min/max labels work normal after this changing, could you check it again? Or give me a specific example ? @Ovilia

MeetzhDing avatar Sep 30 '22 03:09 MeetzhDing

+1 Any news if axisLabel.showMinLabel and axisLabel.showMaxLabel will start working with type time axis ?

leoclo avatar Mar 13 '24 00:03 leoclo