echarts icon indicating copy to clipboard operation
echarts copied to clipboard

feat(sankey): `sankey` support `edgeLabel`

Open susiwen8 opened this issue 2 years ago • 5 comments

Brief Information

This pull request is in the type of:

  • [ ] bug fixing
  • [x] new feature
  • [ ] others

What does this PR do?

Fixed issues

  • Close #7233
  • Close #16600
  • Close #12855

Details

Before: What was the problem?

Sankey don't have label on edges

Screen Shot 2022-03-29 at 11 18 24 PM

After: How is it fixed in this PR?

Screen Shot 2022-03-29 at 11 18 36 PM

Misc

  • [x] The API has been changed (apache/echarts-doc#xxx).
  • [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

test/sankey-depth.html

Others

Merging options

  • [x] Please squash the commits into a single one when merging.

Other information

susiwen8 avatar Mar 29 '22 15:03 susiwen8

Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

echarts-bot[bot] avatar Mar 29 '22 15:03 echarts-bot[bot]

@pissang It's there anything else you need to leave a review for this PR

susiwen8 avatar Apr 26 '22 14:04 susiwen8

Any more suggestion? @pissang @plainheart

susiwen8 avatar May 05 '22 03:05 susiwen8

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

echarts-bot[bot] avatar Jun 29 '22 01:06 echarts-bot[bot]

@pissang Any suggestion for this feature?

susiwen8 avatar Aug 10 '22 15:08 susiwen8

Waiting for this feature.

Nemecsek avatar Oct 14 '22 08:10 Nemecsek

Sorry for missing this PR. LGTM now

pissang avatar Oct 16 '22 08:10 pissang

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

echarts-bot[bot] avatar Oct 16 '22 08:10 echarts-bot[bot]

Has this feature release? I set "edgeLabel" in sankey is not work

Tiramisupxl avatar Dec 01 '22 07:12 Tiramisupxl

@Tiramisupxl Not yet. This feature is included in v5.4.1, which is under the voting process.

plainheart avatar Dec 01 '22 14:12 plainheart