eagle
eagle copied to clipboard
apache
[EAGLE-985] Upgrade hbase dependency to 1.2.5
+1, LGTM, I will be testing this on my dev environment as well sometime tomorrow.
@jhsenjaliya @tedyu After this upgrade, does we still support HBase 0.98?
Hi @qingwen220 no, since there are some function signature changes here, I dont think it will be compatible. ( without those changes, it is compatible though) so the question really comes down to whether we want to support 0.98 till 0.5 release then this can be pushed to 0.6 when majority of the tech stack is going to change ( storm, kafka, etc..), comment?
Yes. We expect after 0.5, Eagle can support Kafka 0.10 & storm 0.10.
There is a concern. We have a coprocessor module in Eagle for HBase 0.98. I am not sure if we could support this function after upgrade
Should we have multiple version support for HBase(Storm/Kafka etc) so that users can still use old versions if they cannot switch to new version quickly? I think it will be better if we have some abstractions first instead of doing like this.
In my opition ,we should do more test before upgrade to hbase 1.2.5 rather than just solve compile problem.
master works fine with hbase 1.2.2 I am planning to test this patch with hbase 1.2.5 tonight
@tedyu I pulled your PR and used ur code to run my eagle, I am running alert engine app + hdfs audit log app and it successfully created the alert i was expecting. so this PR is working fine. but As i mentioned earlier, I was using hbase 1.2.2 and also tested hbase 1.2.5 without any code change to eagle and it was working fine as well. so probably these changes are not mandatory but good to follow newer hbase functions.
@qingwen220 , @r7raul1984 looks like we can accommodate hbase 1.2.5 with or without this PR changes but I havent tested with hbase coprocessor enabled. so if someone can test current eagle code with hbase 1.2.5 with coprocessor enabled, we can make decision on whether we can include hbase upgrade in eagle 0.5 or later.