eagle icon indicating copy to clipboard operation
eagle copied to clipboard

Published 20 hours ago • verified publisher icon apache

[EAGLE-740]Fix eagle-query checkstyle warnings

Open koone opened this issue 8 years ago • 9 comments

[EAGLE-740]Fix eagle-query checkstyle warnings

http://issues.apache.org/jira/browse/EAGLE-740

koone avatar Nov 11 '16 10:11 koone

Classes under org.apache.eagle.query.antlr.generated is automatically generated by antlr, so suggest to exclude it from checkstyle and keep the original code.

haoch avatar Nov 14 '16 02:11 haoch

revert eagle-antlr and exclude Classes under org.apache.eagle.query.antlr.generated from checstyle @haoch could you please check again

koone avatar Nov 14 '16 07:11 koone

Could you please rollback the code format of files under org.apache.eagle.query.antlr.generated too?

haoch avatar Nov 14 '16 11:11 haoch

@haoch the last commit is already roolback the code format

koone avatar Nov 15 '16 02:11 koone

@koone thanks

haoch avatar Nov 15 '16 02:11 haoch

@koone As the PR changed too many files, please it may take a few days for reviewing.

haoch avatar Nov 15 '16 07:11 haoch

@haoch , do you need any help on reviewing this? @koone, Can you please rebase this PR ? Thanks

jhsenjaliya avatar Apr 17 '17 08:04 jhsenjaliya

Hi @koone, This would be good to add in 0.5 branch, would you have time to rebase this and address comments from @haoch ? Thanks

jhsenjaliya avatar May 22 '17 18:05 jhsenjaliya

I spent lot of time in rebasing this, but eventually it got very confusing since there are lot of files ( ~1500) to be rebased, which i did (jhsenjaliya:EAGLE-740-rebased) but there are multiple layers of rebase needs to be done, and i afraid i cant pick the right candidate wherever there are conflicts. so I am leaving this aside for 0.5 release, and we can get to this afterwards. this is important and we should take this change eventually. Thanks

jhsenjaliya avatar Jul 12 '17 22:07 jhsenjaliya