dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

[3.3] Bump com.hazelcast:hazelcast from 3.12.13 to 5.2.5 and start Hazelcast cluster instance before running dubbo-filter-cache test cases

Open zrlw opened this issue 2 weeks ago • 1 comments

What is the purpose of the change?

  1. https://github.com/apache/dubbo/pull/15726 tested failed because Hazelcast 5.2.5 took auto-dection instead of multicast (Hazelcast 3.12.13) as its default discovery mechanism, the test cases will encounter connection trouble if running them on Azure (current Github workflows run on Azure cloud).
2025-12-12T02:01:15.0158978Z Dec 12, 2025 2:01:14 AM com.hazelcast.internal.config.AbstractConfigLocator
2025-12-12T02:01:15.0159755Z INFO: Loading 'hazelcast-client-default.xml' from the classpath.
2025-12-12T02:01:15.3137849Z Dec 12, 2025 2:01:15 AM com.hazelcast.spi.discovery.integration.DiscoveryService
2025-12-12T02:01:15.3139551Z INFO: _hzinstance_jcache_shared [dev] [5.2.5] Auto-detection selected discovery strategy: class com.hazelcast.azure.AzureDiscoveryStrategyFactory
2025-12-12T02:01:15.3145352Z Dec 12, 2025 2:01:15 AM com.hazelcast.client.impl.spi.ClientInvocationService
2025-12-12T02:01:15.3146514Z INFO: _hzinstance_jcache_shared [dev] [5.2.5] Running with 2 response threads, dynamic=true
2025-12-12T02:01:15.4159001Z Dec 12, 2025 2:01:15 AM com.hazelcast.core.LifecycleService
2025-12-12T02:01:15.4159858Z INFO: _hzinstance_jcache_shared [dev] [5.2.5] HazelcastClient 5.2.5 (20240223) is STARTING
2025-12-12T02:01:15.4160638Z Dec 12, 2025 2:01:15 AM com.hazelcast.core.LifecycleService
2025-12-12T02:01:15.4161394Z INFO: _hzinstance_jcache_shared [dev] [5.2.5] HazelcastClient 5.2.5 (20240223) is STARTED
2025-12-12T02:01:15.4162674Z Dec 12, 2025 2:01:15 AM com.hazelcast.client.impl.connection.ClientConnectionManager
2025-12-12T02:01:15.4163593Z INFO: _hzinstance_jcache_shared [dev] [5.2.5] Trying to connect to cluster: dev
2025-12-12T02:01:15.4164377Z Dec 12, 2025 2:01:15 AM com.hazelcast.azure.AzureDiscoveryStrategy
2025-12-12T02:01:15.4166036Z WARNING: No Azure credentials found! Starting standalone. To use Hazelcast Azure discovery, configure properties (client-id, tenant-id, client-secret) or assign a managed identity to the Azure Compute instance
2025-12-12T02:01:15.4167937Z Dec 12, 2025 2:01:15 AM com.hazelcast.client.impl.connection.ClientConnectionManager
2025-12-12T02:01:15.4169329Z WARNING: _hzinstance_jcache_shared [dev] [5.2.5] Unable to get live cluster connection, retry in 1000 ms, attempt: 1, cluster connect timeout: INFINITE, max backoff: 30000 ms
       ... ...
  1. Hazelcast client 5.2.5 will retry to connect Hazelcast cluster forever if cluster instance is not started or not accessible.

Checklist

  • [x] Make sure there is a GitHub_issue field for the change.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [x] Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

zrlw avatar Dec 11 '25 07:12 zrlw

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 60.80%. Comparing base (9fffe62) to head (ba1bbde).

Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15837      +/-   ##
============================================
+ Coverage     60.78%   60.80%   +0.01%     
- Complexity    11712    11716       +4     
============================================
  Files          1938     1938              
  Lines         88692    88692              
  Branches      13387    13387              
============================================
+ Hits          53915    53926      +11     
+ Misses        29256    29245      -11     
  Partials       5521     5521              
Flag Coverage Δ
integration-tests-java21 32.32% <ø> (-0.05%) :arrow_down:
integration-tests-java8 32.44% <ø> (-0.02%) :arrow_down:
samples-tests-java21 32.00% <ø> (-0.06%) :arrow_down:
samples-tests-java8 29.70% <ø> (-0.03%) :arrow_down:
unit-tests-java11 59.10% <ø> (+0.03%) :arrow_up:
unit-tests-java17 58.56% <ø> (-0.03%) :arrow_down:
unit-tests-java21 58.60% <ø> (+0.04%) :arrow_up:
unit-tests-java25 58.49% <ø> (-0.05%) :arrow_down:
unit-tests-java8 59.05% <ø> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Dec 11 '25 08:12 codecov-commenter