dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

[GSoC 2025] Add more traffic management rule support for Dubbo Proxyless Mesh.

Open KiteSoar opened this issue 4 months ago • 3 comments

What is the purpose of the change?

its for #15213

  • Preliminarily support the proxyless mesh feature
  • Add more traffic management rule support for Dubbo Proxyless Mesh.

Checklist

  • [x] Make sure there is a GitHub_issue field for the change.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [x] Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

KiteSoar avatar Aug 04 '25 03:08 KiteSoar

please run mvn spotless:apply to format your code

heliang666s avatar Aug 12 '25 05:08 heliang666s

do you open the failing links to check the reason? image

ERROR the following files don't have a valid license header: 
dubbo-demo/dubbo-demo-xds/META-INF/dubbo/internal/org.apache.dubbo.registry.RegistryFactory
dubbo-demo/dubbo-demo-xds/consumer-services.yaml
dubbo-demo/dubbo-demo-xds/destination-rule.yaml
dubbo-demo/dubbo-demo-xds/header-matching-virtualservice.yaml
dubbo-demo/dubbo-demo-xds/kind-config.yaml
dubbo-demo/dubbo-demo-xds/path-matching-virtualservice.yaml
dubbo-demo/dubbo-demo-xds/provider-service.yaml
dubbo-demo/dubbo-demo-xds/provider-v1.yaml
dubbo-demo/dubbo-demo-xds/provider-v2.yaml
dubbo-demo/dubbo-demo-xds/retry-virtualservice.yaml
dubbo-demo/dubbo-demo-xds/service-echo.yaml
dubbo-demo/dubbo-demo-xds/services_remote.yaml
dubbo-demo/dubbo-demo-xds/timeout-virtualservice.yaml
dubbo-demo/dubbo-demo-xds/weight-virtualservice.yaml 

why put these files at the root directory of dubbo-demo-xds? configurations should be located at src/main/resources.

zrlw avatar Aug 26 '25 08:08 zrlw

Codecov Report

:x: Patch coverage is 21.14929% with 3993 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 57.96%. Comparing base (d45ce97) to head (380448d). :warning: Report is 53 commits behind head on 3.3.

Files with missing lines Patch % Lines
...apache/dubbo/xds/resource/XdsListenerResource.java 15.35% 397 Missing and 33 partials :warning:
.../dubbo/xds/resource/XdsRouteConfigureResource.java 29.08% 185 Missing and 32 partials :warning:
.../apache/dubbo/xds/resource/XdsClusterResource.java 26.75% 149 Missing and 18 partials :warning:
...ds/resource/cluster/LoadBalancerConfigFactory.java 3.54% 134 Missing and 2 partials :warning:
.../java/org/apache/dubbo/xds/XdsResourceFactory.java 44.74% 109 Missing and 12 partials :warning:
...che/dubbo/xds/resource/filter/rbac/RbacFilter.java 3.47% 111 Missing :warning:
...esource/listener/security/XdsX509TrustManager.java 0.00% 100 Missing :warning:
...e/dubbo/xds/resource/cluster/OutlierDetection.java 0.00% 94 Missing :warning:
...ache/dubbo/xds/resource/matcher/HeaderMatcher.java 15.45% 92 Missing and 1 partial :warning:
...rg/apache/dubbo/xds/resource/update/CdsUpdate.java 48.86% 85 Missing and 5 partials :warning:
... and 107 more
Additional details and impacted files
@@             Coverage Diff              @@
##                3.3   #15606      +/-   ##
============================================
- Coverage     61.01%   57.96%   -3.06%     
- Complexity    11698    11757      +59     
============================================
  Files          1923     2091     +168     
  Lines         87069    94052    +6983     
  Branches      13112    14348    +1236     
============================================
+ Hits          53124    54514    +1390     
- Misses        28495    33866    +5371     
- Partials       5450     5672     +222     
Flag Coverage Δ
integration-tests-java21 30.68% <1.89%> (-2.23%) :arrow_down:
integration-tests-java8 30.72% <1.89%> (-2.24%) :arrow_down:
samples-tests-java21 30.44% <1.60%> (-2.21%) :arrow_down:
samples-tests-java8 28.29% <1.60%> (-2.01%) :arrow_down:
unit-tests-java11 56.01% <20.84%> (-3.01%) :arrow_down:
unit-tests-java17 55.81% <20.84%> (-2.95%) :arrow_down:
unit-tests-java21 55.80% <20.84%> (-2.96%) :arrow_down:
unit-tests-java8 56.01% <20.95%> (-2.98%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Sep 05 '25 14:09 codecov-commenter