dubbo
dubbo copied to clipboard
Early decode x509 certificate when connection established
What is the purpose of the change?
- Certificate in SSLSession is
javax.security.cert.X509Certificateand cannot load properties like SANs - Only
java.security.cert.X509Certificatesupport get custom properties - Try load
org.apache.dubbo.common.ssl.DubboX509Certificatewhen connection established
Checklist
- [x] Make sure there is a GitHub_issue field for the change.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
- [x] Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?
Codecov Report
:x: Patch coverage is 0% with 76 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 41.36%. Comparing base (2268c29) to head (6c1596a).
:warning: Report is 5 commits behind head on 3.2.
Additional details and impacted files
@@ Coverage Diff @@
## 3.2 #15259 +/- ##
============================================
- Coverage 41.39% 41.36% -0.04%
+ Complexity 10513 10512 -1
============================================
Files 1652 1653 +1
Lines 71438 71514 +76
Branches 10159 10162 +3
============================================
+ Hits 29573 29581 +8
- Misses 37731 37793 +62
- Partials 4134 4140 +6
| Flag | Coverage Δ | |
|---|---|---|
| integration-tests | 38.36% <0.00%> (-0.03%) |
:arrow_down: |
| samples-tests | 36.34% <0.00%> (-0.05%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.