dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

[Bug] Dubbo 3.3.3 Call-Chain of Skywalking not correct

Open ldcsaa opened this issue 10 months ago • 5 comments

Pre-check

  • [x] I am sure that all the content I provide is in English.

Search before asking

  • [x] I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

Dubbo 3.3.3, jdk17

Steps to reproduce this issue

I had upgrade dubbo to version 3.3.3, but the #14925 bug did not fixed !

Image

What you expected to happen

fix bug #14925

Anything else

No response

Are you willing to submit a pull request to fix on your own?

  • [ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

ldcsaa avatar Jan 28 '25 08:01 ldcsaa

Would you like to fix it?

AlbumenJ avatar Jan 28 '25 14:01 AlbumenJ

Would you like to fix it?

I don't hava time ...

ldcsaa avatar Jan 28 '25 17:01 ldcsaa

Would you like to fix it?

I don't hava time ...

How do you collect trace from Java Process? Please show me the configuration thanks.

songxiaosheng avatar Feb 06 '25 01:02 songxiaosheng

Would you like to fix it?

I don't hava time ...

How do you collect trace from Java Process? Please show me the configuration thanks.

@Bean
@Primary
@ConditionalOnMissingBean
ObservationRegistry observationRegistry(List<MeterObservationHandler<?>> handlers, ObservationPredicate predicate)
{
    ObservationRegistry registry = ObservationRegistry.create();

    registry.observationConfig()
        .observationHandler(
            new ObservationHandler.FirstMatchingCompositeObservationHandler(
                new SkywalkingMeterHandler(new SkywalkingMeterRegistry())))
        .observationHandler(
            new ObservationHandler.FirstMatchingCompositeObservationHandler(handlers))
        .observationHandler(
            new ObservationHandler.FirstMatchingCompositeObservationHandler(
                new SkywalkingSenderTracingHandler(),
                new SkywalkingReceiverTracingHandler(),
                new SkywalkingDefaultTracingHandler()))
        .observationPredicate(predicate);
    
    return registry;
}
@AutoConfiguration
@ConditionalOnClass({TraceContext.class, SoaDubboConfig.class})
public class SoaSkyWalkingDubboConfig
{
    @Bean
    ApplicationModel applicationModel(ObservationRegistry observationRegistry)
    {
        ApplicationModel applicationModel = ApplicationModel.defaultModel();
        applicationModel.getBeanFactory().registerBean(observationRegistry);
        
        return applicationModel;
    }
}

ldcsaa avatar Mar 16 '25 15:03 ldcsaa

Would you like to fix it?

I don't hava time ...

How do you collect trace from Java Process? Please show me the configuration thanks.

@Bean
@Primary
@ConditionalOnMissingBean
ObservationRegistry observationRegistry(List<MeterObservationHandler<?>> handlers, ObservationPredicate predicate)
{
    ObservationRegistry registry = ObservationRegistry.create();

    registry.observationConfig()
        .observationHandler(
            new ObservationHandler.FirstMatchingCompositeObservationHandler(
                new SkywalkingMeterHandler(new SkywalkingMeterRegistry())))
        .observationHandler(
            new ObservationHandler.FirstMatchingCompositeObservationHandler(handlers))
        .observationHandler(
            new ObservationHandler.FirstMatchingCompositeObservationHandler(
                new SkywalkingSenderTracingHandler(),
                new SkywalkingReceiverTracingHandler(),
                new SkywalkingDefaultTracingHandler()))
        .observationPredicate(predicate);
    
    return registry;
}
@AutoConfiguration
@ConditionalOnClass({TraceContext.class, SoaDubboConfig.class})
public class SoaSkyWalkingDubboConfig
{
    @Bean
    ApplicationModel applicationModel(ObservationRegistry observationRegistry)
    {
        ApplicationModel applicationModel = ApplicationModel.defaultModel();
        applicationModel.getBeanFactory().registerBean(observationRegistry);
        
        return applicationModel;
    }
}

okay,let me test it pls wait.

songxiaosheng avatar Mar 18 '25 13:03 songxiaosheng