dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

fix judgment for registry configed in DefaultApplicationDeployer

Open laywin opened this issue 1 year ago • 2 comments

What is the purpose of the change?

fix https://github.com/apache/dubbo/issues/14859

Checklist

  • [x] Make sure there is a GitHub_issue field for the change.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] Write necessary unit-test to verify your logic correction. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [x] Make sure gitHub actions can pass. Why the workflow is failing and how to fix it?

laywin avatar Nov 07 '24 14:11 laywin

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 2.19%. Comparing base (ef6e8bd) to head (02c2f20). Report is 88 commits behind head on 3.3.

Additional details and impacted files
@@              Coverage Diff              @@
##              3.3    #14874        +/-   ##
=============================================
- Coverage   37.53%     2.19%    -35.34%     
=============================================
  Files        1813     26083     +24270     
  Lines       80737   1389686   +1308949     
  Branches    12005    220210    +208205     
=============================================
+ Hits        30304     30570       +266     
- Misses      46042   1354680   +1308638     
- Partials     4391      4436        +45     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Nov 08 '24 03:11 codecov-commenter

@chickenlj PTAL

AlbumenJ avatar Nov 13 '24 06:11 AlbumenJ