dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

feat: support prometheus new client of micrometer 1.13.0 version

Open qyi71 opened this issue 1 year ago • 9 comments

What is the purpose of the change

support prometheus new client of micrometer 1.13.0 version #14228

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

qyi71 avatar Jun 19 '24 06:06 qyi71

https://github.com/prometheus/client_java/blob/main/prometheus-metrics-exporter-pushgateway/src/test/java/io/prometheus/metrics/exporter/pushgateway/PushGatewayTest.java

qyi71 avatar Jun 19 '24 10:06 qyi71

image

Case failed

AlbumenJ avatar Jun 20 '24 01:06 AlbumenJ

image

Case failed

can you give me some tips? I don't see any error logs and

qyi71 avatar Jun 20 '24 03:06 qyi71

You can get the case in https://github.com/apache/dubbo-integration-cases/tree/main/99-integration/dubbo-samples-test-13580. Update the dubbo version in pom, and test it.

AlbumenJ avatar Jun 24 '24 09:06 AlbumenJ

You can get the case in https://github.com/apache/dubbo-integration-cases/tree/main/99-integration/dubbo-samples-test-13580. Update the dubbo version in pom, and test it.

Thanks

qyi71 avatar Jun 24 '24 13:06 qyi71

You can get the case in https://github.com/apache/dubbo-integration-cases/tree/main/99-integration/dubbo-samples-test-13580. Update the dubbo version in pom, and test it.

Already solved . I need to modify 'dubbo-integration-cases' project . ref: https://github.com/apache/dubbo-integration-cases/pull/35

qyi71 avatar Jun 25 '24 13:06 qyi71

image

Case failed

i saw it many times, it seemed that it has nothing to do with this pr, it might be caused by HttpUtil.get not returning full response.

zrlw avatar Jun 24 '25 09:06 zrlw

As for me, it might be better to add a new module instead of changing current codes for compatible reason.

zrlw avatar Jun 24 '25 09:06 zrlw