dubbo
dubbo copied to clipboard
[Feature] Allow modules to extend Dubbo application configuration
Pre-check
- [X] I am sure that all the content I provide is in English.
Search before asking
- [X] I had searched in the issues and found no similar feature requirement.
Apache Dubbo Component
Java SDK (apache/dubbo)
Descriptions
Allow modules to extend Dubbo application configuration to support custom configuration in other modules. For example, I expect to define MetricsConfig in the dubbo-metrics module and PromethusConfig in the dubbo-metrics-promethus module. And in the future, I expect to define OtlpConfig in dubbo-metrics-export-otlp.
Related issues
Separate the code for indicator monitoring Refector Metric export
Are you willing to submit a pull request to fix on your own?
- [X] Yes I am willing to submit a pull request on my own!
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
Example : https://github.com/walklown/dubbo-pr/commit/043561fe9fb79c762876f89cd6e428a8a4f12b39
Question :
- AbstractConfig can be removed so that the Config class will be more generic . Is this improvement necessary? I hope to get some suggestions
- Is SPI a good way to implement extended configuration classes? Any better suggestions?
@chickenlj @CrazyHZM @icodening @EarthChen @oxsean PTAL