dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

[Feature] Allow modules to extend Dubbo application configuration

Open walklown opened this issue 1 year ago • 2 comments

Pre-check

  • [X] I am sure that all the content I provide is in English.

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java SDK (apache/dubbo)

Descriptions

Allow modules to extend Dubbo application configuration to support custom configuration in other modules. For example, I expect to define MetricsConfig in the dubbo-metrics module and PromethusConfig in the dubbo-metrics-promethus module. And in the future, I expect to define OtlpConfig in dubbo-metrics-export-otlp.

Related issues

Separate the code for indicator monitoring Refector Metric export

Are you willing to submit a pull request to fix on your own?

  • [X] Yes I am willing to submit a pull request on my own!

Code of Conduct

walklown avatar Jun 11 '24 08:06 walklown

Example : https://github.com/walklown/dubbo-pr/commit/043561fe9fb79c762876f89cd6e428a8a4f12b39

Question :

  1. AbstractConfig can be removed so that the Config class will be more generic . Is this improvement necessary? I hope to get some suggestions
  2. Is SPI a good way to implement extended configuration classes? Any better suggestions?

walklown avatar Jun 11 '24 08:06 walklown

@chickenlj @CrazyHZM @icodening @EarthChen @oxsean PTAL

AlbumenJ avatar Jun 13 '24 02:06 AlbumenJ