dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

Optimize the decoding of generic http2

Open finefuture opened this issue 9 months ago • 7 comments

What is the purpose of the change

When native http2 sends a request, it is possible to send 1-2 data frames:

  1. The data frame is sent together with the endStream identifier
  2. The data frame and endStream identifier are sent separately.

In the second case, when a data frame with the endStream identifier is received and the data is empty, the parameters will be set to null. Loss of parameters will cause the call to fail.

Therefore, it is necessary to set the number of data frames to be received to avoid decoding errors.

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

finefuture avatar May 11 '24 07:05 finefuture

@AlbumenJ The rest protocol has been migrated to the dubbo-spi-extension project. image

finefuture avatar May 11 '24 09:05 finefuture

@oxsean @icodening PTAL

finefuture avatar May 13 '24 02:05 finefuture

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.80%. Comparing base (a12975a) to head (49bd9eb). Report is 80 commits behind head on 3.3.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #14175      +/-   ##
==========================================
+ Coverage   38.55%   38.80%   +0.25%     
==========================================
  Files        1895     1730     -165     
  Lines       79272    75341    -3931     
  Branches    11528    11099     -429     
==========================================
- Hits        30560    29233    -1327     
+ Misses      44439    41969    -2470     
+ Partials     4273     4139     -134     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 14 '24 03:05 codecov-commenter

Can you provider a test case? or how to test it?

oxsean avatar May 16 '24 08:05 oxsean

Can you provider a test case? or how to test it?

Okay, I will provider a demo later.

finefuture avatar May 16 '24 08:05 finefuture

@oxsean This is the demo: https://github.com/finefuture/triple-http2-demo/tree/main

finefuture avatar May 16 '24 12:05 finefuture

LGTM.

oxsean avatar May 21 '24 12:05 oxsean

Native http2 does not support client stream and bi stream (streaming requests are not supported), so we only need to deal with unary and server streams, which means streaming responses are supported.

Receiving the end_stream flag means that the unary data stream is complete and can be decoded.

finefuture avatar May 23 '24 03:05 finefuture