dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

check child is json or not in zookeeper.it will be continue if not.

Open walkinggo opened this issue 1 year ago • 5 comments

What is the purpose of the change

catch the exception when the url can't be deserialization.related issue

Brief changelog

add the json check when ANY_VALUE.equals(url.getServiceInterface()) at ZookeeperRegistry#doSubscribe.

Verifying this change

the child will work normal if the child is json.It can still work when dubbo-admin run.

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x] GitHub Actions works fine on your own branch.

walkinggo avatar May 08 '24 07:05 walkinggo

@CrazyHZM hello,In the last commit, I only make the logger for warnings and did not change any logic. However, it still did not pass the checks.That is strange.I checked the logs, and it seems to be a timeout issue with Zookeeper. Could the success of the checks be related to network factors?

walkinggo avatar May 08 '24 12:05 walkinggo

@AlbumenJ I catch the exception,but i can't pass the CI/CD.I am trying to fix it.

walkinggo avatar May 11 '24 06:05 walkinggo

@AlbumenJ Take a look,please.

walkinggo avatar May 11 '24 09:05 walkinggo

Also, pls add some test cases

AlbumenJ avatar May 13 '24 02:05 AlbumenJ

@AlbumenJ I had finish it,could you take a look please?

walkinggo avatar May 18 '24 05:05 walkinggo