dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

[Feature][3.3] Triple rest jaxrs ParamConverter support

Open fanlobu opened this issue 1 year ago • 8 comments

What is the purpose of the change

Triple rest jaxrs ParamConverter support,related: #14037

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

fanlobu avatar Apr 30 '24 14:04 fanlobu

@oxsean PTAL

AlbumenJ avatar May 08 '24 03:05 AlbumenJ

@fanlobu Is it ready for review?

oxsean avatar May 08 '24 14:05 oxsean

@fanlobu Is it ready for review?

I think it is ok, I did some simple tests in local

fanlobu avatar May 09 '24 03:05 fanlobu

@fanlobu please resolve error-code-inspector error first, You need log with error code

oxsean avatar Jun 09 '24 08:06 oxsean

LGTM.

oxsean avatar Jun 10 '24 05:06 oxsean

@fanlobu please resolve error-code-inspector error first, You need log with error code

Thanks for all the suggestions for my code changes, I've done all the changes, but CICDtest runs failed, I checked the logs but didn't find a solution. Does this test run fail have anything to do with my commit ?

fanlobu avatar Jun 10 '24 06:06 fanlobu

Looks like a timeout, you can make a small change, like an empty line or a comment, to trigger the CI again.

oxsean avatar Jun 10 '24 07:06 oxsean