dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

Separate the code for indicator monitoring

Open walklown opened this issue 1 year ago • 15 comments

What is the purpose of the change

[Task] Separate the code for indicator monitoring #14016

Brief changelog

1、Refer to Spring Event Multicaster, improve Dubbo Event Multicaster, and migrate to dubbo-common package. 2、Replace the MetricsEvent that occur in Dubbo with DubboEvent and broadcast them through Dubbo Event Multicaster. Remove the dependence on dubbo-metrics and only retain the dependence on dubbo-metrics-api. Please note that dubbo-plugin and dubbo-spring-boot still retain a dependency on dubbo-metrics-default because they require some advanced capabilities. 3、Split Collector and CollectorEventListener, and convert DubboEvent into MetricsEvent in CollectorEventListener. 4、Add the dubbo-metrics-starter package to listen to DubboEvent and initialize the metrics service at the appropriate time. Merge dubbo-metrics-event and dubbo-metrics-api into dubbo-metrics-core package, and only keep necessary interfaces and annotations in dubbo-metrics-api.

Verifying this change

Submitted DubboEventTest to test dubbo Dubbo Event Multicaster. Passed all unit tests.

walklown avatar Apr 21 '24 13:04 walklown

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.83%. Comparing base (a12975a) to head (76484fc). Report is 140 commits behind head on 3.3.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #14106      +/-   ##
==========================================
+ Coverage   38.55%   38.83%   +0.28%     
==========================================
  Files        1895     1753     -142     
  Lines       79272    75860    -3412     
  Branches    11528    11208     -320     
==========================================
- Hits        30560    29461    -1099     
+ Misses      44439    42257    -2182     
+ Partials     4273     4142     -131     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 21 '24 14:04 codecov-commenter

@songxiaosheng PTAL

walklown avatar Apr 22 '24 02:04 walklown

The check item 'dubbo-samples-test-13787' failed because the tests attribute in 'case-configuration.yml' was set incorrectly. Waitting for fix.

walklown avatar May 10 '24 06:05 walklown

The check item 'dubbo-samples-test-13787' failed because the tests attribute in 'case-configuration.yml' was set incorrectly. Waitting for fix.

Fixed in https://github.com/apache/dubbo-integration-cases/pull/25

AlbumenJ avatar May 11 '24 06:05 AlbumenJ

please resolve conflicts

songxiaosheng avatar May 16 '24 10:05 songxiaosheng

please resolve conflicts

Resolved ~

walklown avatar May 16 '24 11:05 walklown

@CrazyHZM Hello, 2 weeks have passed, is there have any new suggestions?

walklown avatar May 29 '24 05:05 walklown

@CrazyHZM Hello, 2 weeks have passed, is there have any new suggestions?

@AlbumenJ @CrazyHZM Looking forward to new news.

walklown avatar Jun 05 '24 11:06 walklown

"[error]The action 'Test with Maven with SonarCloud Scan' has timed out after 90 minutes." happens again. I have no idea about the reason. It would be great if someone could give some hints. Thanks.

walklown avatar Jun 11 '24 09:06 walklown

"[error]The action 'Test with Maven with SonarCloud Scan' has timed out after 90 minutes." happens again. I have no idea about the reason. It would be great if someone could give some hints. Thanks.

@AlbumenJ Thanks for your help. Notice that you triggered a retry, but the results are still not satisfactory.

`Run curl "http://dubbo-vm.apache.org:8000/token?workflow_id=9461697580" -o /home/runner/work/dubbo/dubbo/.tmp/encrypted-sonarcloud-token % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 128 100 128 0 0 114 0 0:00:01 0:00:01 --:--:-- 114 100 128 100 128 0 0 114 0 0:00:01 0:00:01 --:--:-- 114 The command rsautl was deprecated in version 3.0. Use 'pkeyutl' instead. Could not open file or uri for loading private key from /home/runner/work/dubbo/dubbo/.tmp/rsa/rsa_private.pem 40E788EC087F0000:error:16000069:STORE routines:ossl_store_get0_loader_int:unregistered scheme:../crypto/store/store_register.c:237:scheme=file 40E788EC087F0000:error:80000002:system library:file_open:No such file or directory:../providers/implementations/storemgmt/file_store.c:267:calling stat(/home/runner/work/dubbo/dubbo/.tmp/rsa/rsa_private.pem) Error: Process completed with exit code 1.`

walklown avatar Jun 13 '24 15:06 walklown

@CrazyHZM Hello, 3 weeks have passed, is there have any new suggestions?

walklown avatar Jul 07 '24 15:07 walklown

@CrazyHZM Hello, 3 weeks have passed, is there have any new suggestions?

@AlbumenJ @CrazyHZM Looking forward to new news.

walklown avatar Jul 13 '24 08:07 walklown