dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

[Feature 3.3] Triple Rest Cors Support

Open Rawven opened this issue 10 months ago • 3 comments

What is the purpose of the change

Detailed description is in this issue [#13965 ]
I have added a demo test for this new feature to the 3.3-triple-cors branch of the fork's dubbo-sample repository, and used the sample repository to pass ci on my own branch. This is link https://github.com/Rawven/dubbo/pull/7

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [x] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

Rawven avatar Apr 12 '24 07:04 Rawven

@oxsean PTAL

Rawven avatar Apr 22 '24 13:04 Rawven

@oxsean I have modified all the parts you mentioned PTAL

Rawven avatar Apr 24 '24 11:04 Rawven

@AlbumenJ LGTM.

oxsean avatar May 20 '24 06:05 oxsean

@AlbumenJ PTAL I have fix the license,but it looks like the latest commit of the integration test will make the workflow fail

Rawven avatar May 21 '24 07:05 Rawven