dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

[Feature] Move Mesh Rule Router to SPI Extensions

Open heliang666s opened this issue 10 months ago • 3 comments

What is the purpose of the change

[Feature] Move Mesh Rule Router to SPI Extensions

Brief changelog

  • copy all the related classes to org.apache.dubbo.rpc.cluster.configurator.parser.model

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

heliang666s avatar Apr 11 '24 11:04 heliang666s

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 11 '24 13:04 sonarqubecloud[bot]

This error is due to the version definition problem of dubbo-samples project with Dubbo-samples-meshrule-router Supported component versions of the test case, It can be asked if it is necessary to additionally exclude 3.3 @songxiaosheng image

Like the dubbo-samples-consu module, the tests were skipped because of version

wcy666103 avatar Apr 11 '24 13:04 wcy666103

Yes,I clone dubbo-samples code,I find the same problem.@wcy666103

heliang666s avatar Apr 11 '24 13:04 heliang666s