dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

[Dependency] Exclude transitive spring dependencies from dubbo-all or dubbo-spring-boot-starter

Open chickenlj opened this issue 10 months ago • 6 comments

Pre-check

  • [X] I am sure that all the content I provide is in English.

Search before asking

  • [X] I had searched in the issues and found no similar issues.

Apache Dubbo Component

Java SDK (apache/dubbo)

Dubbo Version

3.3.0-beta.2

Steps to reproduce this issue

Remove the following transitive dependencies from dubbo-all, if not possible, at least exclude them in dubbo-spring-boot-starter.

  <!-- Transitive dependencies -->
    <dependency>
      <groupId>org.springframework</groupId>
      <artifactId>spring-core</artifactId>
    </dependency>
    <dependency>
      <groupId>org.springframework</groupId>
      <artifactId>spring-beans</artifactId>
    </dependency>
    <dependency>
      <groupId>org.springframework</groupId>
      <artifactId>spring-context</artifactId>
    </dependency>

Try to completely get rid of the following dependency:

    <dependency>
      <groupId>com.alibaba.spring</groupId>
      <artifactId>spring-context-support</artifactId>
    </dependency>

What you expected to happen

  • When using spring, the recommended way is spring boot, so transitive spring dependencies is not necessary, let spring-boot-starter do this for users.
  • When using API, we don't need spring dependencies.

Anything else

No response

Are you willing to submit a pull request to fix on your own?

  • [ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

chickenlj avatar Apr 05 '24 10:04 chickenlj

hello,I think I can do it,please assign me,thanks~

heliang666s avatar Apr 05 '24 10:04 heliang666s

hello,I think I can do it,please assign me,thanks~

done

AlbumenJ avatar Apr 07 '24 06:04 AlbumenJ

@AlbumenJ You seem to be getting people wrong

heliang666s avatar Apr 07 '24 06:04 heliang666s

@AlbumenJ You seem to be getting people wrong

My fault😭

AlbumenJ avatar Apr 08 '24 08:04 AlbumenJ

transitive dependencies exists 3.3.0-Beta.3

fastkdm avatar Jun 20 '24 16:06 fastkdm

transitive dependencies exists 3.3.0-Beta.3

Yes, it hasn't been merged yet, details are here https://github.com/apache/dubbo/pull/14137

wcy666103 avatar Jun 21 '24 02:06 wcy666103