dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard
verified publisher icon apache

[Feature] Merge CommonConfigPostProcessor and ConfigPostProcessor

Open AlbumenJ opened this issue 1 year ago • 8 comments

Pre-check

  • [X] I am sure that all the content I provide is in English.

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java SDK (apache/dubbo)

Descriptions

Merge CommonConfigPostProcessor and ConfigPostProcessor in dubbo-common

Related issues

No response

Are you willing to submit a pull request to fix on your own?

  • [ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

AlbumenJ avatar Mar 20 '24 03:03 AlbumenJ

hello,I am new there,I want to try this,thank you!

heliang666s avatar Mar 21 '24 14:03 heliang666s

hello,I am new there,I want to try this,thank you!

Please go ahead

AlbumenJ avatar Mar 22 '24 02:03 AlbumenJ

Could you assign it to me? Thanks~

heliang666s avatar Mar 22 '24 02:03 heliang666s

Could you assign it to me? Thanks~

Done. @heliang666s

CrazyHZM avatar Mar 25 '24 03:03 CrazyHZM

I have some questions, ask for help there is my modifylog:

  • create src/main/java/org/apache/dubbo/config/CommonConfigPostProcessor.java;(because there is no CommonConfigPostProcessor but need to merge)
  • move ConfigPostProcessor to src/main/java/org/apache/dubbo/config/CommonConfigPostProcessor.java;
  • Modify dependencies 图片 图片 This creates a dependency loop, I don't know how to fix it, please give a suggestion, thanks

heliang666s avatar Apr 01 '24 04:04 heliang666s

  1. CommonConfigPostProcessor is in 3.3 branch
  2. Because dubbo-rpc-rest is going to be moved to dubbo-spi-extensions in https://github.com/apache/dubbo/issues/13958, we can prevent the dependency loop

AlbumenJ avatar Apr 02 '24 06:04 AlbumenJ

图片 Firstly,The pr is always error at the this check point.I don`t know how to fix it.

图片

Secondly, I find https://github.com/apache/dubbo/issues/13958 has merged into apache/dubbo-spi-extensions,but did not merge into apache/dubbo 3.3,the dependency loop is still there.I try to change the vision in pom.xml.But I think it`s not a good solution.Please give a suggestion, thanks~

heliang666s avatar Apr 07 '24 15:04 heliang666s

图片 Firstly,The pr is always error at the this check point.I don`t know how to fix it.

图片

Secondly, I find #13958 has merged into apache/dubbo-spi-extensions,but did not merge into apache/dubbo 3.3,the dependency loop is still there.I try to change the vision in pom.xml.But I think it`s not a good solution.Please give a suggestion, thanks~

After https://github.com/apache/dubbo-spi-extensions/pull/306 merge, we can remove all the implementation of REST protocol in 3.3 branch

AlbumenJ avatar Apr 08 '24 08:04 AlbumenJ