dubbo
dubbo copied to clipboard
optimize the same weight judgement
What is the purpose of the change
optimize the same weight judgement
Brief changelog
Move the logic to determine if the weights are the same before accumulation. So we can reduce addition operations
Verifying this change
Checklist
- [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
- [ ] Add some description to dubbo-website project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the Software Donation Guide.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.45%. Comparing base (
afcf04d) to head (44d7627).
Additional details and impacted files
@@ Coverage Diff @@
## 3.2 #13949 +/- ##
==========================================
+ Coverage 70.43% 70.45% +0.01%
==========================================
Files 1607 1607
Lines 70075 70075
Branches 10100 10100
==========================================
+ Hits 49360 49373 +13
+ Misses 16080 16071 -9
+ Partials 4635 4631 -4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.