fix multi application context when use AwaitingNonWebApplicationListener
What is the purpose of the change
fix https://github.com/apache/dubbo/issues/13722
Brief changelog
-
remove root application context judgment condition, the AwaitingNonWebApplicationListener can only be invoked in the application context which it registered.
-
add shutdownHookCallback member variable to ensure there is only one shutdownHookCallback instance to register
Verifying this change
Checklist
- [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
- [ ] Add some description to dubbo-website project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the Software Donation Guide.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.51%. Comparing base (
0553d70) to head (00ccb03).
Additional details and impacted files
@@ Coverage Diff @@
## 3.2 #13908 +/- ##
==========================================
- Coverage 70.52% 70.51% -0.01%
==========================================
Files 1607 1607
Lines 70071 70071
Branches 10100 10100
==========================================
- Hits 49419 49412 -7
- Misses 16030 16037 +7
Partials 4622 4622
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@AlbumenJ PTAL