dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

[Task] Monitoring indicators support otel format indicator export

Open songxiaosheng opened this issue 1 year ago • 5 comments

Pre-check

  • [X] I am sure that all the content I provide is in English.

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java SDK (apache/dubbo)

Descriptions

Currently, dubbo indicators support the use of micromter, but do not support the export of otel format. They need to be compatible with the otel format exporter.

Related issues

No response

Are you willing to submit a pull request to fix on your own?

  • [ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

songxiaosheng avatar Mar 11 '24 10:03 songxiaosheng

may be we can use export adapter like spring-boot

ShenFeng312 avatar Mar 13 '24 06:03 ShenFeng312

https://github.com/spring-projects/spring-boot/blob/main/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/metrics/export/otlp/OtlpMetricsExportAutoConfiguration.java

ShenFeng312 avatar Mar 13 '24 06:03 ShenFeng312

I would like to take over this task, please assign it to me. @songxiaosheng

glmapper avatar Mar 17 '24 02:03 glmapper

I finished the initial coding and testing, here are my design ideas and some sample data, I hope to submit it to the community and then discuss it together!

  1. add new module dubbo-metrics/dubbo-metrics-otlp,the primary purpose is to introduce a dependency
<dependency>
    <groupId>io.micrometer</groupId>
    <artifactId>micrometer-registry-otlp</artifactId>
  </dependency>
  1. Same as the default and prometheus, provide OtlpMetricsReporter and OtlpMetricsReporterFactory to support otlp protocol format data.
  2. there are no other changes, if you want use otlp, pls config dubbo.metrics.protocol=otlp to appoint you protocol type

consumer site promethues protocol data:

metrics-prometheus.json

consumer site otlp protocol data: metrics-otlp.json

glmapper avatar Apr 02 '24 10:04 glmapper

Okay, you can submit a PR

songxiaosheng avatar Apr 07 '24 13:04 songxiaosheng