dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

[Task] Some of the sample guidance conforms to business usage

Open AlbumenJ opened this issue 1 year ago • 6 comments

Pre-check

  • [X] I am sure that all the content I provide is in English.

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component

Java Samples (apache/dubbo-samples)

Descriptions

  1. EmbeddedZookeeper: Change to a regular zookeeper download, install startup commands
  2. Change samples to normal applications instead of directly loading XML within the Main function.

Related issues

https://github.com/apache/dubbo/discussions/13847

Are you willing to submit a pull request to fix on your own?

  • [ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

AlbumenJ avatar Mar 08 '24 06:03 AlbumenJ

@AlbumenJ Is embedded-zookeeper being removed here in dubbo-examples? and replace XML load to application.yaml configuration way?

https://github.com/apache/dubbo-samples/blob/c79de2129e20c07d6572c6a09519d48b6ec50781/3-extensions/protocol/dubbo-samples-webservice/dubbo-samples-webservice-provider/src/main/java/org/apache/dubbo/samples/webservice/provider/WebserviceProvider.java#L27

If so, please assign to me and I will try to complete this.

yuluo-yx avatar Mar 24 '24 14:03 yuluo-yx

@yuluo-yx Yes, you can refer to other samples that have been completed.

CrazyHZM avatar Mar 25 '24 02:03 CrazyHZM

@yuluo-yx Yes, you can refer to other samples that have been completed.

Is there a pr link to an example? I didn't find a pr associated with the current issue. Can I submit a pr as a separate commit for removing zookeeper and updating xml? There seems to be no correlation between the two

yuluo-yx avatar Mar 25 '24 13:03 yuluo-yx

ptal @CrazyHZM

https://github.com/apache/dubbo-samples/pull/1115

yuluo-yx avatar Mar 27 '24 14:03 yuluo-yx

Hey, I want to try this issues. Can anyone guide me?

vishakha-mali avatar Jan 23 '25 12:01 vishakha-mali

Hello, I’m a new contributor to this project and I’m interested in working on this issue. Kindly assign it to me so I can get started. Thank you!

RishiMenpara avatar Nov 02 '25 18:11 RishiMenpara