dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

Refactor 3.3 grpc http2 processes

Open finefuture opened this issue 1 year ago • 4 comments

What is the purpose of the change

  1. Get the MethodDescriptor before building the HttpMessageListener, and try not to go through the data frame parsing MethodDescriptor, reduce memory copy and duplicate processes.
  2. Use PackableMethod for grpc encoding and decoding function, stay the same way with triple invoker.

3 3-packable

image

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

finefuture avatar Feb 23 '24 06:02 finefuture

@oxsean PTAL

AlbumenJ avatar Feb 23 '24 07:02 AlbumenJ

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.51%. Comparing base (b338e20) to head (472869a).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #13786      +/-   ##
==========================================
- Coverage   38.53%   38.51%   -0.02%     
==========================================
  Files        1894     1892       -2     
  Lines       79274    79189      -85     
  Branches    11529    11522       -7     
==========================================
- Hits        30547    30500      -47     
+ Misses      44427    44399      -28     
+ Partials     4300     4290      -10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 06 '24 03:03 codecov-commenter