dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

opt: improve readability in AbstractConditionMatcher

Open Linchen-Xu opened this issue 2 years ago • 1 comments

What is the purpose of the change

Reformat codes and comments in AbstractConditionMatcher to improve readability. The previous code used three ifs to separately indicate what should be done in three conditions. They all do the same thing:

  1. Check mismatch conditions and return false if any one of these conditions is met.
  2. Check match conditions and return true if any one of these conditions is met.
  3. Return true if there are only mismatch rules (which means the matcher is only used to exclude cases). Otherwise, return false.

Therefore, we can combine the three situations into unified logic, which makes it easier for other users to understand the code.

Brief changelog

Reformat codes and comments in org.apache.dubbo.rpc.cluster.router.condition.matcher.AbstractConditionMatcher#isMatch.

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x] Each commit in the pull request should have a meaningful subject line and body.
  • [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

Linchen-Xu avatar Nov 27 '23 17:11 Linchen-Xu