dubbo
dubbo copied to clipboard
opt: add comments and optimize logic in RandomLoadBalance
What is the purpose of the change
- Add comments in
RandomLoadBalanceto make it easier for people to understand its logic. - Rewrite a part of its logic to improve efficiency. Assuming the difference between the expected index to be found and the index returned by
Arrays.binarySearchisgap(for example, the returned index is 1 while the expected is 3, then the gap is 2), the previous logic will calculate i2 * gaptimes. However, this will be reduced to onlygaptimes after rewriting.
Brief changelog
- Add comments and optimize logic in
org.apache.dubbo.rpc.cluster.loadbalance.RandomLoadBalance.
Verifying this change
Checklist
- [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
- [ ] Add some description to dubbo-website project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the Software Donation Guide.








