dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

Remove unused code

Open EarthChen opened this issue 2 years ago • 2 comments

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

EarthChen avatar Feb 04 '23 12:02 EarthChen

Codecov Report

Merging #11459 (a51cb1e) into 3.1 (34b92b0) will increase coverage by 0.21%. The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.1   #11459      +/-   ##
============================================
+ Coverage     64.67%   64.89%   +0.21%     
  Complexity       14       14              
============================================
  Files          1431     1502      +71     
  Lines         59969    62734    +2765     
  Branches       8807     9162     +355     
============================================
+ Hits          38786    40712    +1926     
- Misses        17111    17786     +675     
- Partials       4072     4236     +164     
Impacted Files Coverage Δ
...ri/transport/TripleHttp2ClientResponseHandler.java 91.42% <ø> (-0.24%) :arrow_down:
.../serialize/hessian2/Hessian2SerializerFactory.java 0.00% <0.00%> (-100.00%) :arrow_down:
...mmon/serialize/hessian2/Hessian2Serialization.java 15.38% <0.00%> (-76.93%) :arrow_down:
...ommon/serialize/hessian2/Hessian2ObjectOutput.java 0.00% <0.00%> (-37.84%) :arrow_down:
...common/serialize/hessian2/Hessian2ObjectInput.java 0.00% <0.00%> (-37.50%) :arrow_down:
...o/rpc/protocol/tri/transport/GracefulShutdown.java 51.85% <0.00%> (-29.63%) :arrow_down:
...mon/serialize/hessian2/Hessian2FactoryManager.java 14.28% <0.00%> (-24.49%) :arrow_down:
...bbo/remoting/buffer/ChannelBufferOutputStream.java 68.75% <0.00%> (-18.75%) :arrow_down:
...ache/dubbo/rpc/protocol/dubbo/DubboCountCodec.java 76.31% <0.00%> (-14.31%) :arrow_down:
...common/serialize/DefaultMultipleSerialization.java 85.71% <0.00%> (-14.29%) :arrow_down:
... and 368 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Feb 04 '23 13:02 codecov-commenter