dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

Polish ObservationConfiguration

Open ShenFeng312 opened this issue 2 years ago • 2 comments

What is the purpose of the change

1.Polish ObservationConfiguration 2.Fix slf4JEventListener

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

ShenFeng312 avatar Feb 04 '23 05:02 ShenFeng312

Codecov Report

Merging #11456 (6cf6f57) into 3.2 (75fd3fe) will decrease coverage by 4.80%. The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11456      +/-   ##
============================================
- Coverage     69.70%   64.91%   -4.80%     
+ Complexity      131       14     -117     
============================================
  Files          1551     1501      -50     
  Lines         83499    62712   -20787     
  Branches      14874     9160    -5714     
============================================
- Hits          58205    40711   -17494     
+ Misses        20400    17768    -2632     
+ Partials       4894     4233     -661     
Impacted Files Coverage Δ
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) :arrow_down:
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) :arrow_down:
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) :arrow_down:
.../serialize/hessian2/Hessian2SerializerFactory.java 0.00% <0.00%> (-100.00%) :arrow_down:
...nfigure/DubboRelaxedBinding2AutoConfiguration.java 0.00% <0.00%> (-100.00%) :arrow_down:
.../apache/dubbo/test/spring/SpringXmlConfigTest.java 0.00% <0.00%> (-96.16%) :arrow_down:
...egistrycenter/context/ZookeeperWindowsContext.java 0.00% <0.00%> (-81.82%) :arrow_down:
...istrycenter/processor/FindPidWindowsProcessor.java 5.40% <0.00%> (-81.09%) :arrow_down:
...pc/cluster/router/file/FileStateRouterFactory.java 0.00% <0.00%> (-80.96%) :arrow_down:
...ycenter/processor/KillProcessWindowsProcessor.java 10.00% <0.00%> (-80.00%) :arrow_down:
... and 498 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Feb 04 '23 06:02 codecov-commenter