dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

Fix tri future

Open EarthChen opened this issue 2 years ago • 2 comments

What is the purpose of the change

fix https://github.com/apache/dubbo/issues/11447 not stub

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

EarthChen avatar Feb 03 '23 14:02 EarthChen

Codecov Report

Merging #11455 (bbf6007) into 3.1 (34b92b0) will decrease coverage by 0.04%. The diff coverage is 25.00%.

@@             Coverage Diff              @@
##                3.1   #11455      +/-   ##
============================================
- Coverage     64.67%   64.63%   -0.04%     
  Complexity       14       14              
============================================
  Files          1431     1431              
  Lines         59969    59971       +2     
  Branches       8807     8807              
============================================
- Hits          38786    38765      -21     
- Misses        17111    17124      +13     
- Partials       4072     4082      +10     
Impacted Files Coverage Δ
...ubbo/rpc/protocol/tri/call/AbstractServerCall.java 51.12% <0.00%> (-0.59%) :arrow_down:
...bbo/rpc/protocol/tri/ReflectionPackableMethod.java 77.22% <50.00%> (ø)
...gistrycenter/processor/ZookeeperUnixProcessor.java 60.71% <0.00%> (-17.86%) :arrow_down:
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 64.28% <0.00%> (-9.53%) :arrow_down:
...g/apache/dubbo/remoting/api/ConnectionHandler.java 51.51% <0.00%> (-9.10%) :arrow_down:
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (-8.70%) :arrow_down:
...e/dubbo/remoting/transport/netty/NettyChannel.java 51.13% <0.00%> (-7.96%) :arrow_down:
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.64% <0.00%> (-3.23%) :arrow_down:
.../dubbo/remoting/transport/netty4/NettyChannel.java 72.64% <0.00%> (-2.84%) :arrow_down:
...ntext/event/AwaitingNonWebApplicationListener.java 70.66% <0.00%> (-1.34%) :arrow_down:
... and 9 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Feb 04 '23 05:02 codecov-commenter