dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

Enhance Check

Open AlbumenJ opened this issue 2 years ago • 2 comments

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

AlbumenJ avatar Jan 30 '23 13:01 AlbumenJ

Codecov Report

Merging #11419 (8102d62) into 3.1 (f1b3e55) will increase coverage by 0.06%. The diff coverage is 92.74%.

@@             Coverage Diff              @@
##                3.1   #11419      +/-   ##
============================================
+ Coverage     64.56%   64.63%   +0.06%     
  Complexity       14       14              
============================================
  Files          1428     1428              
  Lines         59779    59891     +112     
  Branches       8794     8805      +11     
============================================
+ Hits          38598    38710     +112     
- Misses        17101    17113      +12     
+ Partials       4080     4068      -12     
Impacted Files Coverage Δ
...e/dubbo/common/utils/AllowClassNotifyListener.java 100.00% <ø> (ø)
.../serialize/fastjson2/Fastjson2SecurityManager.java 43.54% <64.00%> (+10.21%) :arrow_up:
...mon/serialize/hessian2/Hessian2FactoryManager.java 38.77% <66.66%> (ø)
...he/dubbo/rpc/protocol/ProtocolSecurityWrapper.java 83.78% <84.61%> (-9.55%) :arrow_down:
...bo/common/utils/SerializeSecurityConfigurator.java 94.73% <94.73%> (ø)
...bbo/common/utils/DefaultSerializeClassChecker.java 92.77% <95.74%> (ø)
...ache/dubbo/common/CommonScopeModelInitializer.java 100.00% <100.00%> (ø)
...e/dubbo/common/beanutil/JavaBeanSerializeUtil.java 80.79% <100.00%> (-0.07%) :arrow_down:
.../java/org/apache/dubbo/common/utils/PojoUtils.java 75.88% <100.00%> (-0.06%) :arrow_down:
...pache/dubbo/common/utils/SerializeCheckStatus.java 100.00% <100.00%> (ø)
... and 17 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jan 31 '23 02:01 codecov-commenter

@CrazyHZM PTAL

chickenlj avatar Feb 01 '23 07:02 chickenlj