dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

Replace instanceof with Matchers#instanceOf in test cases

Open mxsm opened this issue 2 years ago • 2 comments

  • [x] I have searched the issues of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 3.2
  • Operating System version: ALL
  • Java version: xxx

Steps to reproduce this issue

In some test cases use instanceof, for example ExtensionTest class image we can replace with Matchers#instanceOf

Expected Behavior

MatcherAssert.assertThat(myfactory, Matchers.instanceOf(ExtensionInjector.class));

Actual Behavior

mxsm avatar Jan 28 '23 09:01 mxsm

Would you pls submit a PR to enhance?

AlbumenJ avatar Jan 30 '23 03:01 AlbumenJ

@AlbumenJ I will submit a pr to do this later

mxsm avatar Jan 30 '23 03:01 mxsm

hi @AlbumenJ @mxsm still working on this? I'd like to work on it

elroykanye avatar Mar 11 '23 14:03 elroykanye

hi @AlbumenJ @mxsm still working on this? I'd like to work on it

I'm working on this.

mxsm avatar Mar 11 '23 14:03 mxsm