dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

move metrics from common to dubbo-metrics

Open wxbty opened this issue 2 years ago • 6 comments

What is the purpose of the change

The content of metrics should not be placed in the common package

Brief changelog

move to dubbo-metrics,add a separate dubbo-metrics-default package, dubbo-metrics-api only needs interfaces and javabeans

wxbty avatar Jan 27 '23 14:01 wxbty

@songxiaosheng PTAL

AlbumenJ avatar Jan 28 '23 03:01 AlbumenJ

@wxbty Exception in thread "main" java.lang.IllegalStateException: No such extension org.apache.dubbo.metrics.service.MetricsServiceExporter by name default, no related exception was found, please check whether related SPI module is missing. at org.apache.dubbo.common.extension.ExtensionLoader.findException(ExtensionLoader.java:760) at org.apache.dubbo.common.extension.ExtensionLoader.createExtension(ExtensionLoader.java:767) at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:561) at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:535) at org.apache.dubbo.common.extension.ExtensionLoader.getDefaultExtension(ExtensionLoader.java:587) at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.initMetricsService(DefaultApplicationDeployer.java:356) at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.initialize(DefaultApplicationDeployer.java:212) at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.start(DefaultApplicationDeployer.java:611) at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:226) at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:215) at com.apache.dubbo.demo.graalvm.consumer.Application.runWithBootstrap(Application.java:68) at com.apache.dubbo.demo.graalvm.consumer.Application.main(Application.java:40) Error: Process completed with exit code 1.

songxiaosheng avatar Jan 28 '23 13:01 songxiaosheng

@wxbty Exception in thread "main" java.lang.IllegalStateException: No such extension org.apache.dubbo.metrics.service.MetricsServiceExporter by name default, no related exception was found, please check whether related SPI module is missing. at org.apache.dubbo.common.extension.ExtensionLoader.findException(ExtensionLoader.java:760) at org.apache.dubbo.common.extension.ExtensionLoader.createExtension(ExtensionLoader.java:767) at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:561) at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:535) at org.apache.dubbo.common.extension.ExtensionLoader.getDefaultExtension(ExtensionLoader.java:587) at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.initMetricsService(DefaultApplicationDeployer.java:356) at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.initialize(DefaultApplicationDeployer.java:212) at org.apache.dubbo.config.deploy.DefaultApplicationDeployer.start(DefaultApplicationDeployer.java:611) at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:226) at org.apache.dubbo.config.bootstrap.DubboBootstrap.start(DubboBootstrap.java:215) at com.apache.dubbo.demo.graalvm.consumer.Application.runWithBootstrap(Application.java:68) at com.apache.dubbo.demo.graalvm.consumer.Application.main(Application.java:40) Error: Process completed with exit code 1.

done

wxbty avatar Jan 28 '23 15:01 wxbty

Codecov Report

Merging #11386 (6616818) into 3.2 (f73eee9) will decrease coverage by 4.66%. The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                3.2   #11386      +/-   ##
============================================
- Coverage     69.46%   64.81%   -4.66%     
+ Complexity      119       14     -105     
============================================
  Files          1525     1499      -26     
  Lines         82581    62544   -20037     
  Branches      14708     9149    -5559     
============================================
- Hits          57364    40536   -16828     
+ Misses        20339    17777    -2562     
+ Partials       4878     4231     -647     
Impacted Files Coverage Δ
...ubbo/config/deploy/DefaultApplicationDeployer.java 72.23% <ø> (-9.47%) :arrow_down:
...o/config/deploy/DefaultMetricsServiceExporter.java 79.48% <ø> (ø)
...a/org/apache/dubbo/metrics/event/MetricsEvent.java 57.14% <ø> (ø)
...n/java/org/apache/dubbo/metrics/event/RTEvent.java 66.66% <ø> (ø)
...a/org/apache/dubbo/metrics/event/RequestEvent.java 86.66% <ø> (ø)
...a/org/apache/dubbo/metrics/model/MethodMetric.java 67.56% <ø> (ø)
...rg/apache/dubbo/metrics/model/MetricsCategory.java 100.00% <ø> (ø)
...ava/org/apache/dubbo/metrics/model/MetricsKey.java 100.00% <ø> (ø)
.../dubbo/metrics/model/sample/GaugeMetricSample.java 100.00% <ø> (ø)
...pache/dubbo/metrics/model/sample/MetricSample.java 52.38% <ø> (ø)
... and 503 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Jan 29 '23 08:01 codecov-commenter

image

AlbumenJ avatar Jan 30 '23 06:01 AlbumenJ