dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

Observability tasks: verify how skywalking connects to the micrometer

Open conghuhu opened this issue 2 years ago • 12 comments

  • [x] I have searched the issues of this repository and believe that this is not a duplicate.

Describe the proposal

中文: 需验证下micrometer怎么和skywalking集成。

en: Verify how the micrometer integrates with skywalking.

conghuhu avatar Jan 06 '23 08:01 conghuhu

I'm interested in this task, and I think it is relevant to the issue?

mufiye avatar Feb 03 '23 05:02 mufiye

cc @AlbumenJ

conghuhu avatar Feb 03 '23 06:02 conghuhu

@mufiye You can refer to this article about current issue.

When verifying, you can refer to use samples.

The target is to report dubbo trace information to skywalking.

conghuhu avatar Feb 03 '23 07:02 conghuhu

@mufiye You can refer to this article about current issue.

When verifying, you can refer to use samples.

The target is to report dubbo trace information to skywalking.

I think I get it, I will learn and do it. So if I have done the verification, should I do a pull request to the dubbo-samples repository? @conghuhu

mufiye avatar Feb 03 '23 10:02 mufiye

ok, You can create a new module.

conghuhu avatar Feb 03 '23 10:02 conghuhu

ok, You can create a new module.

And one more question is should I consider the "metrics" data? I see this task is below "链路追踪" in #issue11113 which I think is about "trace".

mufiye avatar Feb 03 '23 10:02 mufiye

You can do tracing first. When need metrics later, you can add.

conghuhu avatar Feb 03 '23 10:02 conghuhu

You can do tracing first. When need metrics later, you can add.

Ok.

mufiye avatar Feb 03 '23 10:02 mufiye

Do we have to use otel bridge to integrate with skywalking? I think to integrate skywalking, we just use the skywalking agent API the article you send to me. And when we start the dubbo application, we should do the instrument with skywalking-java-agent jar. Then we can use the skywalking oap to get trace data. @conghuhu

mufiye avatar Feb 03 '23 12:02 mufiye

You're right. This issue has forgotten to update. Micrometer can directly connect with skywalking

conghuhu avatar Feb 03 '23 13:02 conghuhu

You're right. This issue has forgotten to update. Micrometer can directly connect with skywalking

I get it.

mufiye avatar Feb 03 '23 13:02 mufiye

I have done the verification. As a result, the micrometer trace data can integrate with skywalking and I call pull request #724 to submit the sample codes. @conghuhu

mufiye avatar Feb 07 '23 09:02 mufiye