Enhance service discovery update interval
What is the purpose of the change
Try update service discovery for each 1s
- When application is starting, refresh each 30s
- When service is updating, refresh each 5s
Brief changelog
Verifying this change
Checklist
- [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
- [ ] Add some description to dubbo-website project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the Software Donation Guide.
Codecov Report
Merging #11223 (d76c25e) into 3.2 (3375f72) will increase coverage by
0.03%. The diff coverage is60.71%.
@@ Coverage Diff @@
## 3.2 #11223 +/- ##
============================================
+ Coverage 64.82% 64.86% +0.03%
Complexity 14 14
============================================
Files 1479 1479
Lines 61532 61556 +24
Branches 9021 9023 +2
============================================
+ Hits 39888 39928 +40
+ Misses 17451 17445 -6
+ Partials 4193 4183 -10
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...a/org/apache/dubbo/metadata/MetadataConstants.java | 0.00% <ø> (ø) |
|
| ...e/dubbo/registry/integration/RegistryProtocol.java | 59.53% <55.55%> (-0.10%) |
:arrow_down: |
| ...ubbo/config/deploy/DefaultApplicationDeployer.java | 72.54% <70.00%> (-0.05%) |
:arrow_down: |
| ...ache/dubbo/common/extension/ExtensionDirector.java | 93.33% <0.00%> (-3.34%) |
:arrow_down: |
| ...vent/listener/ServiceInstancesChangedListener.java | 79.75% <0.00%> (+0.41%) |
:arrow_up: |
| ...moting/transport/netty4/NettyConnectionClient.java | 74.83% <0.00%> (+0.64%) |
:arrow_up: |
| ...bo/rpc/cluster/support/AbstractClusterInvoker.java | 79.47% <0.00%> (+0.66%) |
:arrow_up: |
| .../dubbo/remoting/transport/netty4/NettyChannel.java | 75.71% <0.00%> (+0.71%) |
:arrow_up: |
| ...e/dubbo/remoting/transport/netty/NettyChannel.java | 56.81% <0.00%> (+1.13%) |
:arrow_up: |
| .../src/main/java/org/apache/dubbo/rpc/RpcStatus.java | 82.14% <0.00%> (+1.19%) |
:arrow_up: |
| ... and 11 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
[25/39] [dubbo-samples-isolation-executor:1/1] TEST FAILURE: Run tests timeout, version: -Ddubbo.version=3.2.0-beta.4-SNAPSHOT -Dspring.version=4.3.30.RELEASE -Djava.version=8, please check logs: /home/runner/work/dubbo/dubbo/99-integration/dubbo-samples-isolation-executor/target/logs
Is this integration failure expected?
[25/39] [dubbo-samples-isolation-executor:1/1] TEST FAILURE: Run tests timeout, version: -Ddubbo.version=3.2.0-beta.4-SNAPSHOT -Dspring.version=4.3.30.RELEASE -Djava.version=8, please check logs: /home/runner/work/dubbo/dubbo/99-integration/dubbo-samples-isolation-executor/target/logs
Fix in https://github.com/apache/dubbo-samples/pull/704







