dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard
verified publisher icon apache

Add 'label match' support for override and tag rules

Open chickenlj opened this issue 3 years ago • 4 comments

Related to #11091 and #11090

chickenlj avatar Dec 08 '22 07:12 chickenlj

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

66.9% 66.9% Coverage
4.4% 4.4% Duplication

sonarqubecloud[bot] avatar Dec 08 '22 09:12 sonarqubecloud[bot]

Codecov Report

Merging #11094 (e233a17) into 3.2 (5d07038) will decrease coverage by 0.02%. The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11094      +/-   ##
============================================
- Coverage     69.35%   69.34%   -0.02%     
  Complexity        2        2              
============================================
  Files          1461     1479      +18     
  Lines         61612    62083     +471     
  Branches       9068     9152      +84     
============================================
+ Hits          42729    43049     +320     
- Misses        14708    14811     +103     
- Partials       4175     4223      +48
Impacted Files Coverage Δ
...apache/dubbo/rpc/cluster/router/tag/model/Tag.java 73.07% <0.00%> (-19.24%) :arrow_down:
...stry/integration/AbstractConfiguratorListener.java 75.55% <0.00%> (-13.34%) :arrow_down:
...er/mesh/rule/virtualservice/match/StringMatch.java 87.87% <0.00%> (-12.13%) :arrow_down:
...e/dubbo/remoting/transport/netty/NettyChannel.java 47.72% <0.00%> (-7.96%) :arrow_down:
...cluster/router/condition/ConditionStateRouter.java 61.29% <0.00%> (-7.68%) :arrow_down:
.../dubbo/common/url/component/ServiceAddressURL.java 47.25% <0.00%> (-6.50%) :arrow_down:
...oting/transport/netty4/NettyConnectionHandler.java 53.19% <0.00%> (-6.39%) :arrow_down:
.../apache/dubbo/remoting/transport/AbstractPeer.java 67.39% <0.00%> (-4.35%) :arrow_down:
...bo/rpc/cluster/router/tag/model/TagRuleParser.java 62.50% <0.00%> (-4.17%) :arrow_down:
...apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java 56.00% <0.00%> (-4.00%) :arrow_down:
... and 48 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Dec 08 '22 09:12 codecov-commenter

@chickenlj Please commit this change to the 3.2 branch.

CrazyHZM avatar Dec 09 '22 05:12 CrazyHZM

@chickenlj Please commit this change to the 3.2 branch.

I have changed the target branch to 3.2

chickenlj avatar Dec 10 '22 08:12 chickenlj 

[08:42:11:011]  INFO utils.SerializeSecurityConfigurator:  [DUBBO] Read serialize blocked list from jar:file:/usr/local/dubbo/app/dependency/dubbo-3.2.0-beta.6-SNAPSHOT.jar!/security/serialize.blockedlist, dubbo version: 3.2.0-beta.6-SNAPSHOT, current host: 172.27.0.3
Tests run: 11, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.066 s <<< FAILURE! - in org.apache.dubbo.sample.tri.direct.TriDirectPojoClientTest
testBoxed(org.apache.dubbo.sample.tri.direct.TriDirectPojoClientTest)  Time elapsed: 0.134 s
greetStream(org.apache.dubbo.sample.tri.direct.TriDirectPojoClientTest)  Time elapsed: 0.028 s
greetUnaryResponseVoid(org.apache.dubbo.sample.tri.direct.TriDirectPojoClientTest)  Time elapsed: 0.01 s
unaryFuture(org.apache.dubbo.sample.tri.direct.TriDirectPojoClientTest)  Time elapsed: 0.012 s
greetUnary(org.apache.dubbo.sample.tri.direct.TriDirectPojoClientTest)  Time elapsed: 0.018 s
greetChildPojo(org.apache.dubbo.sample.tri.direct.TriDirectPojoClientTest)  Time elapsed: 0.016 s
greetServerStream(org.apache.dubbo.sample.tri.direct.TriDirectPojoClientTest)  Time elapsed: 0.017 s
greetUnaryRequestVoid(org.apache.dubbo.sample.tri.direct.TriDirectPojoClientTest)  Time elapsed: 0.008 s
overload(org.apache.dubbo.sample.tri.direct.TriDirectPojoClientTest)  Time elapsed: 0.014 s
greetException(org.apache.dubbo.sample.tri.direct.TriDirectPojoClientTest)  Time elapsed: 0.036 s  <<< FAILURE!
java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.fail(Assert.java:96)
	at org.apache.dubbo.sample.tri.BaseTriPojoClientTest.greetException(BaseTriPojoClientTest.java:116)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray2(ReflectionUtils.java:206)
	at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:161)
	at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:84)
	at org.apache.dubbo.test.runner.ClassloaderSurefireStarter.runSuitesInProcess(ClassloaderSurefireStarter.java:78)
	at org.apache.dubbo.test.runner.TestRunnerMain.runInJunit4(TestRunnerMain.java:233)
	at org.apache.dubbo.test.runner.TestRunnerMain.main(TestRunnerMain.java:156)

greetLong(org.apache.dubbo.sample.tri.direct.TriDirectPojoClientTest)  Time elapsed: 1.466 s

chickenlj avatar Feb 17 '23 12:02 chickenlj

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 20 Code Smells

59.4% 59.4% Coverage
4.2% 4.2% Duplication

sonarqubecloud[bot] avatar Feb 25 '23 10:02 sonarqubecloud[bot]