dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

Micrometer Observation Support

Open marcingrzejszczak opened this issue 3 years ago • 1 comments

  • [x] I have searched the issues of this repository and believe that this is not a duplicate.
  • [x] I have searched the release notes of this repository and believe that this is not a duplicate.

Describe the feature

I'm a co-maintainer of Spring Cloud Sleuth and Micrometer projects (together with @shakuzen and @jonatan-ivanov).

Spring Cloud Sleuth 3.1.x is the last line of Spring Cloud Sleuth. There will be no Spring Cloud Sleuth 3.2 nor 4.0 (you can read more here). There will be no Spring Boot 3 compatible version of Spring Cloud Sleuth. Sleuth will be replaced by Micrometer Observation and Micrometer Tracing.

Micrometer Observation is coming as part of the Micrometer 1.10 release and Micrometer Tracing is a new project. The idea of Micrometer Observation is that you instrument code once but you get multiple benefits out of it - e.g. you can get tracing, metrics, logging or whatever you see fit). In terms of deadlines - Micrometer 1.10.0 GA is planned for 7.11 at the moment (https://github.com/micrometer-metrics/micrometer/milestone/177).

Since Dubbo already support Micrometer I was curious if there's interest in adding Micrometer Observation support so that automatically (when on classpath) except for metrics, spans could be created and tracing context propagation could happen too. If there's such interest we could provide a PR to add support for that.

marcingrzejszczak avatar Oct 12 '22 18:10 marcingrzejszczak

Sounds great! Please go ahead.

AlbumenJ avatar Oct 13 '22 02:10 AlbumenJ

Hey I've created a PR (https://github.com/apache/dubbo/pull/11021) and I did my best there ;) ~~unfortunately I had no luck in running any samples to start 2 dubbo apps to perform some end to end tests so I guess I'll need some help there.~~

I've added some configuration and dependencies to the Boot sample. In the PR I've added screenshots and metrics output for reference.

marcingrzejszczak avatar Nov 24 '22 14:11 marcingrzejszczak