dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

Multiple dubboServices dynamically configure monitoring coverage

Open Shy-Chen opened this issue 3 years ago • 1 comments

Fix the OverrideListener coverage problem of multiple dubboServices when exporting dubbo applications. Because registryUrl is used as the key, only one dubboService can listen to the configuration when the dynamic configuration is issued.

Fix #10670

Shy-Chen avatar Sep 26 '22 06:09 Shy-Chen

Codecov Report

Merging #10673 (0e0ed74) into 3.1 (eb0e25e) will decrease coverage by 0.02%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.1   #10673      +/-   ##
============================================
- Coverage     65.24%   65.21%   -0.03%     
- Complexity      493      494       +1     
============================================
  Files          1336     1336              
  Lines         56918    56930      +12     
  Branches       8434     8421      -13     
============================================
- Hits          37134    37128       -6     
- Misses        15813    15850      +37     
+ Partials       3971     3952      -19     
Impacted Files Coverage Δ
...e/dubbo/registry/integration/RegistryProtocol.java 62.67% <100.00%> (+2.17%) :arrow_up:
...pache/dubbo/common/function/ThrowableFunction.java 71.42% <0.00%> (-28.58%) :arrow_down:
.../remoting/api/SingleProtocolConnectionManager.java 61.53% <0.00%> (-23.08%) :arrow_down:
...he/dubbo/rpc/listener/ListenerExporterWrapper.java 68.00% <0.00%> (-20.00%) :arrow_down:
...ubbo/qos/command/decoder/TelnetCommandDecoder.java 60.00% <0.00%> (-12.73%) :arrow_down:
...ian2/dubbo/AbstractHessian2FactoryInitializer.java 50.00% <0.00%> (-11.12%) :arrow_down:
...pache/dubbo/remoting/transport/AbstractServer.java 61.03% <0.00%> (-3.90%) :arrow_down:
.../apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java 63.51% <0.00%> (-3.63%) :arrow_down:
...java/org/apache/dubbo/remoting/api/Connection.java 80.00% <0.00%> (-2.50%) :arrow_down:
...mmon/threadpool/support/AbortPolicyWithReport.java 81.81% <0.00%> (-2.40%) :arrow_down:
... and 36 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 26 '22 07:09 codecov-commenter