dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

fix (#10458) doUnregister 递归调用

Open liufeiyu1002 opened this issue 3 years ago • 1 comments

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

liufeiyu1002 avatar Aug 15 '22 13:08 liufeiyu1002

Codecov Report

Merging #10464 (7783be0) into 3.1 (551f820) will decrease coverage by 0.09%. The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.1   #10464      +/-   ##
============================================
- Coverage     65.45%   65.36%   -0.10%     
+ Complexity      296      295       -1     
============================================
  Files          1274     1274              
  Lines         54948    54947       -1     
  Branches       8285     8285              
============================================
- Hits          35966    35914      -52     
- Misses        15073    15116      +43     
- Partials       3909     3917       +8     
Impacted Files Coverage Δ
...gistry/client/ReflectionBasedServiceDiscovery.java 0.00% <ø> (ø)
...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java 70.19% <0.00%> (-10.58%) :arrow_down:
.../common/threadpool/serial/SerializingExecutor.java 70.37% <0.00%> (-7.41%) :arrow_down:
...rg/apache/dubbo/rpc/protocol/dubbo/DubboCodec.java 65.21% <0.00%> (-4.35%) :arrow_down:
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 66.97% <0.00%> (-3.67%) :arrow_down:
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) :arrow_down:
...ubbo/common/url/component/param/DynamicValues.java 78.12% <0.00%> (-3.13%) :arrow_down:
...ache/dubbo/rpc/protocol/dubbo/DubboCountCodec.java 90.62% <0.00%> (-3.13%) :arrow_down:
.../apache/dubbo/remoting/transport/CodecSupport.java 80.30% <0.00%> (-3.04%) :arrow_down:
.../dubbo/registry/client/metadata/MetadataUtils.java 69.15% <0.00%> (-2.81%) :arrow_down:
... and 14 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Aug 15 '22 13:08 codecov-commenter