dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

fix for issue#10415

Open chenziqiang666 opened this issue 2 years ago • 2 comments

add catch ConstraintViolationException

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

chenziqiang666 avatar Aug 10 '22 01:08 chenziqiang666

fix #10415

chenziqiang666 avatar Aug 10 '22 02:08 chenziqiang666

Codecov Report

Merging #10431 (9a8a401) into 3.0 (4b55862) will decrease coverage by 0.00%. The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                3.0   #10431      +/-   ##
============================================
- Coverage     65.66%   65.65%   -0.01%     
+ Complexity      319      318       -1     
============================================
  Files          1234     1234              
  Lines         53916    53917       +1     
  Branches       8155     8156       +1     
============================================
- Hits          35402    35399       -3     
+ Misses        14664    14663       -1     
- Partials       3850     3855       +5     
Impacted Files Coverage Δ
.../validation/support/jvalidation/JValidatorNew.java 0.00% <0.00%> (ø)
...bbo/validation/support/jvalidation/JValidator.java 70.98% <100.00%> (-0.89%) :arrow_down:
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) :arrow_down:
...pache/dubbo/registry/support/AbstractRegistry.java 74.91% <0.00%> (-2.44%) :arrow_down:
...registry/zookeeper/util/CuratorFrameworkUtils.java 72.22% <0.00%> (-2.23%) :arrow_down:
...ting/zookeeper/curator/CuratorZookeeperClient.java 68.53% <0.00%> (-1.73%) :arrow_down:
...a/org/apache/dubbo/config/ReferenceConfigBase.java 62.87% <0.00%> (-1.62%) :arrow_down:
...ubbo/registry/client/AbstractServiceDiscovery.java 88.37% <0.00%> (-1.56%) :arrow_down:
...n/java/org/apache/dubbo/config/ConsumerConfig.java 91.17% <0.00%> (-0.72%) :arrow_down:
... and 7 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov-commenter avatar Aug 10 '22 02:08 codecov-commenter