dubbo
dubbo copied to clipboard
fix RpcContext's asyncCall method invoke an interface that returns a value of type 'boolean' always returns 'false'
What is the purpose of the change
fix RpcContext's asyncCall method invoke an interface that returns a value of type 'boolean' always returns 'false'
Brief changelog
Verifying this change
- Write an mock DemoService as provider wiht an interface test() return 'boolean'
- Set @Reference(injvm = false)
- Call DemoService.test() with RpcContext.getContext().asyncCall()
- No matter what the test() method returns, the result is always false
Checklist
- [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
- [ ] Add some description to dubbo-website project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the Software Donation Guide.
Codecov Report
Merging #10258 (eb6640a) into master (bbcb26c) will increase coverage by
0.02%. The diff coverage is0.00%.
@@ Coverage Diff @@
## master #10258 +/- ##
============================================
+ Coverage 60.91% 60.93% +0.02%
- Complexity 447 448 +1
============================================
Files 1100 1100
Lines 44511 44513 +2
Branches 6486 6487 +1
============================================
+ Hits 27115 27126 +11
+ Misses 14430 14425 -5
+ Partials 2966 2962 -4
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...src/main/java/org/apache/dubbo/rpc/RpcContext.java | 66.17% <0.00%> (-0.66%) |
:arrow_down: |
| .../apache/dubbo/remoting/transport/AbstractPeer.java | 58.69% <0.00%> (-4.35%) |
:arrow_down: |
| ...ting/zookeeper/curator/CuratorZookeeperClient.java | 69.51% <0.00%> (-1.07%) |
:arrow_down: |
| ...apache/dubbo/common/extension/ExtensionLoader.java | 80.41% <0.00%> (+0.41%) |
:arrow_up: |
| ...dubbo/remoting/exchange/support/DefaultFuture.java | 89.18% <0.00%> (+0.90%) |
:arrow_up: |
| ...pache/dubbo/registry/support/AbstractRegistry.java | 80.74% <0.00%> (+1.11%) |
:arrow_up: |
| ...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java | 88.57% <0.00%> (+1.90%) |
:arrow_up: |
| ...ubbo/registry/support/AbstractRegistryFactory.java | 83.09% <0.00%> (+2.81%) |
:arrow_up: |
| ...he/dubbo/remoting/transport/netty/NettyServer.java | 73.68% <0.00%> (+3.50%) |
:arrow_up: |
| .../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java | 72.41% <0.00%> (+10.34%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update bbcb26c...eb6640a. Read the comment docs.
This same issue like #10248 If use async call invoke a local service without remote call, this will break the result.