dubbo icon indicating copy to clipboard operation
dubbo copied to clipboard

refactor: optimize ExtensionLoader code style

Open linjianming02 opened this issue 2 years ago • 1 comments

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • [x] Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • [ ] Add some description to dubbo-website project if you are requesting to add a feature.
  • [ ] GitHub Actions works fine on your own branch.
  • [ ] If this contribution is large, please follow the Software Donation Guide.

linjianming02 avatar Jun 28 '22 13:06 linjianming02

Codecov Report

Merging #10229 (6988dcd) into master (f1ca2b4) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master   #10229      +/-   ##
============================================
- Coverage     60.93%   60.93%   -0.01%     
- Complexity      446      449       +3     
============================================
  Files          1100     1100              
  Lines         44582    44495      -87     
  Branches       6494     6483      -11     
============================================
- Hits          27167    27113      -54     
+ Misses        14446    14418      -28     
+ Partials       2969     2964       -5     
Impacted Files Coverage Δ
...apache/dubbo/common/extension/ExtensionLoader.java 79.52% <100.00%> (-0.69%) :arrow_down:
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-13.80%) :arrow_down:
.../exchange/support/header/HeaderExchangeServer.java 67.61% <0.00%> (-2.86%) :arrow_down:
...common/serialize/hessian2/Hessian2ObjectInput.java 90.47% <0.00%> (-1.53%) :arrow_down:
...ommon/serialize/hessian2/Hessian2ObjectOutput.java 93.93% <0.00%> (-0.66%) :arrow_down:
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 80.20% <0.00%> (+0.48%) :arrow_up:
...ting/zookeeper/curator/CuratorZookeeperClient.java 69.51% <0.00%> (+1.06%) :arrow_up:
...pache/dubbo/registry/support/AbstractRegistry.java 80.74% <0.00%> (+1.11%) :arrow_up:
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 73.80% <0.00%> (+1.19%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f1ca2b4...6988dcd. Read the comment docs.

codecov-commenter avatar Jun 29 '22 03:06 codecov-commenter