dubbo-js icon indicating copy to clipboard operation
dubbo-js copied to clipboard

feat: Improve RPC communication based on HTTP/2

Open SDUWYS opened this issue 1 year ago • 6 comments

fix: #362 The initial version of the HTTP/2 code can be improved gradually.

SDUWYS avatar Aug 24 '24 09:08 SDUWYS

@jianyi-gronk CR

SDUWYS avatar Aug 24 '24 09:08 SDUWYS

这个是怎么自测的诶,有写单元测试吗

jianyi-gronk avatar Aug 26 '24 15:08 jianyi-gronk

这个是怎么自测的诶,有写单元测试吗

这个自测单元没写,example例子实现了一下

SDUWYS avatar Aug 26 '24 15:08 SDUWYS

感觉单测还是有必要的吧,比如没带 serviceVersion 和 serviceGroup,或者只带了其中一个参数,或者请求失败场景啥的

jianyi-gronk avatar Aug 26 '24 15:08 jianyi-gronk

感觉单测还是有必要的吧,比如没带 serviceVersion 和 serviceGroup,或者只带了其中一个参数,或者请求失败场景啥的

OK,那我找个时间把这个单测整一下,我看看怎么去单测一下。

SDUWYS avatar Aug 26 '24 15:08 SDUWYS

Quality Gate Failed Quality Gate failed

Failed conditions
14.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Oct 26 '24 10:10 sonarqubecloud[bot]