dubbo-go icon indicating copy to clipboard operation
dubbo-go copied to clipboard

fix: optimization of Serve in server/server.go

Open y138g opened this issue 3 weeks ago • 6 comments

fix: resolved the issue of the Serve() method causing the program to hang indefinitely through graceful_shutdown #3042

y138g avatar Dec 02 '25 16:12 y138g

nice!

97ZQ avatar Dec 03 '25 01:12 97ZQ

现在有很多携程会监听shutdown信号,在shutdown的时候都会输出log,能不能把这些输出的log 文字统一一下

2025-12-04 10:47:38   INFO    graceful_shutdown/shutdown.go:90    get signal interrupt, applicationConfig will shutdown.
2025-12-04 10:47:38     INFO    server/server.go:226    Received signal: interrupt, server is shutting down gracefully
2025-12-04 10:47:38     INFO    graceful_shutdown/shutdown.go:148   Graceful shutdown --- Destroy all registriesConfig. 
2025-12-04 10:47:38     INFO    cmd/server.go:132       Received signal: interrupt, shutting down...

Alanxtl avatar Dec 04 '25 02:12 Alanxtl

all right!

y138g avatar Dec 04 '25 06:12 y138g

Codecov Report

:x: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 37.06%. Comparing base (1a7b169) to head (0325d18). :warning: Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
graceful_shutdown/shutdown.go 0.00% 17 Missing :warning:
server/server.go 0.00% 16 Missing :warning:
config/graceful_shutdown.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3099      +/-   ##
===========================================
- Coverage    39.64%   37.06%   -2.58%     
===========================================
  Files          457      460       +3     
  Lines        39075    32984    -6091     
===========================================
- Hits         15493    12227    -3266     
+ Misses       22318    19531    -2787     
+ Partials      1264     1226      -38     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Dec 11 '25 05:12 codecov-commenter

pls fix copilot comments

Alanxtl avatar Dec 11 '25 06:12 Alanxtl