dubbo-go icon indicating copy to clipboard operation
dubbo-go copied to clipboard

[WIP] CLI: Support getting metadata from metadataCenter

Open Leospard opened this issue 3 years ago • 2 comments

What this PR does:

Which issue(s) this PR fixes: Fixes #

You should pay attention to items below to ensure your pr passes our ci test We do not merge pr with ci tests failed

  • [ ] All ut passed (run 'go test ./...' in project root)
  • [ ] After go-fmt ed , run 'go fmt project' using goland.
  • [ ] Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • [x] Your new-created file needs to have apache license at the top, like other existed file does.
  • [ ] All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

Leospard avatar Sep 30 '22 04:09 Leospard

Codecov Report

Merging #2066 (0b2095e) into 3.0 (aab693f) will decrease coverage by 0.00%. The diff coverage is 61.33%.

@@            Coverage Diff             @@
##              3.0    #2066      +/-   ##
==========================================
- Coverage   44.59%   44.59%   -0.01%     
==========================================
  Files         283      281       -2     
  Lines       17073    16836     -237     
==========================================
- Hits         7614     7508     -106     
+ Misses       8653     8540     -113     
+ Partials      806      788      -18     
Impacted Files Coverage Δ
cluster/cluster/zoneaware/cluster_interceptor.go 40.00% <ø> (ø)
cluster/router/tag/router.go 59.64% <ø> (ø)
common/url.go 59.50% <0.00%> (+0.45%) :arrow_up:
config/config_loader.go 17.56% <0.00%> (ø)
config/consumer_config.go 22.58% <0.00%> (ø)
config/graceful_shutdown.go 3.88% <0.00%> (ø)
config/provider_config.go 41.53% <0.00%> (ø)
config/service_config.go 53.04% <0.00%> (ø)
metadata/identifier/base_metadata_identifier.go 86.48% <0.00%> (-7.64%) :arrow_down:
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (ø)
... and 20 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 30 '22 04:09 codecov-commenter

LGTM,pls updae the readme

cjphaha avatar Sep 30 '22 06:09 cjphaha