dubbo-go-pixiu icon indicating copy to clipboard operation
dubbo-go-pixiu copied to clipboard

[ASoC 2022] Optimization of Pixiu timeout feature

Open CSWYF3634076 opened this issue 2 years ago • 6 comments

What this PR does: timeout for pixiu Which issue(s) this PR fixes:

Fixes #431 Special notes for your reviewer: 对于http2http&https 使用直接在client req中添加timeout的方式 对于htp2grpc 和 http2triple 使用在ctx中添加timeout的方式实现超时 对于http2dubbo 使用在dubbo请求添加超时的方式,使用了 timeout_config --> request_timeout: 1ns 实现,我看这个字段还没有被使用 image 完善中。。。 Does this PR introduce a user-facing change?: yes ,需要在config下添加超时条件,例如 timeout :1ns image


CSWYF3634076 avatar Aug 27 '22 14:08 CSWYF3634076

fix the ut

mark4z avatar Aug 28 '22 13:08 mark4z

fix the git conflict

mark4z avatar Sep 04 '22 10:09 mark4z

fix the ut

get

CSWYF3634076 avatar Sep 04 '22 10:09 CSWYF3634076

fix the git conflict

get

CSWYF3634076 avatar Sep 04 '22 10:09 CSWYF3634076

fix ut

mark4z avatar Sep 16 '22 07:09 mark4z

Codecov Report

Merging #475 (b44077e) into develop (5301405) will decrease coverage by 0.05%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #475      +/-   ##
===========================================
- Coverage    54.97%   54.92%   -0.06%     
===========================================
  Files          662      662              
  Lines        77433    77440       +7     
===========================================
- Hits         42572    42537      -35     
- Misses       31246    31279      +33     
- Partials      3615     3624       +9     
Impacted Files Coverage Δ
pixiu/pkg/client/dubbo/dubbo.go 18.01% <0.00%> (-0.58%) :arrow_down:
pixiu/pkg/client/http/http.go 42.16% <0.00%> (ø)
pixiu/pkg/client/request.go 0.00% <ø> (ø)
pixiu/pkg/common/http/manager.go 42.30% <0.00%> (-0.55%) :arrow_down:
pixiu/pkg/context/http/context.go 0.00% <0.00%> (ø)
security/pkg/credentialfetcher/fetcher.go 40.00% <0.00%> (-20.00%) :arrow_down:
pkg/envoy/admin.go 50.00% <0.00%> (-9.68%) :arrow_down:
pilot/pkg/model/addressmap.go 63.23% <0.00%> (-4.42%) :arrow_down:
pkg/istio-agent/xds_proxy_delta.go 51.29% <0.00%> (-4.15%) :arrow_down:
pilot/pkg/model/service.go 44.79% <0.00%> (-2.72%) :arrow_down:
... and 12 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 17 '22 04:09 codecov-commenter